Reenable Rollup Jobs API test that was failing due to interval change…

… in ES. (#36310)
elastic · May 9, 2019 · a3eaa8f · a3eaa8f
1 parent d0180af
commit a3eaa8f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/x-pack/plugins/rollup/public/crud_app/services/jobs.js b/x-pack/plugins/rollup/public/crud_app/services/jobs.js
@@ -86,7 +86,9 @@ export function deserializeJob(job) {
       metrics,
       groups: {
         date_histogram: {
-          interval: dateHistogramInterval,
+          interval,
+          fixed_interval: fixedInterval,
+          calendar_interval: calendarInterval,
           delay: rollupDelay,
           time_zone: dateHistogramTimeZone,
           field: dateHistogramField,
@@ -108,6 +110,10 @@ export function deserializeJob(job) {
 
   const json = job;
 
+  // `interval` is deprecated but still supported. All three of the various interval types are
+  // mutually exclusive.
+  const dateHistogramInterval = interval || fixedInterval || calendarInterval;
+
   const deserializedJob = {
     id,
     indexPattern,

diff --git a/x-pack/test/api_integration/apis/management/rollup/rollup.js b/x-pack/test/api_integration/apis/management/rollup/rollup.js
@@ -124,8 +124,7 @@ export default function ({ getService }) {
           expect(job.config.rollup_index).to.eql(payload.job.rollup_index);
         });
 
-        // broken after snapshot update: https://github.com/elastic/kibana/issues/36269
-        it.skip('should create the underlying rollup index with the correct aggregations', async () => {
+        it('should create the underlying rollup index with the correct aggregations', async () => {
           await createJob(getJobPayload(indexName));
 
           const { body } = await supertest.get(`${API_BASE_PATH}/indices`);
@@ -139,7 +138,11 @@ export default function ({ getService }) {
                   'testCreatedField': {
                     'agg': 'date_histogram',
                     'delay': '1d',
-                    'interval': '24h',
+                    // TODO: Note that we created the job with `interval`, but ES has coerced this to
+                    // `fixed_interval` based on the value we provided. Once we update the UI and
+                    // tests to no longer use the deprecated `interval` property, we can remove
+                    // this comment.
+                    'fixed_interval': '24h',
                     'time_zone': 'UTC'
                   }
                 },