[i18n] Optimize translation labels for Roles page (#26945)

* [i18n] Optimize translation labels * Usage of ng-if instead of ng-show
elastic · Dec 12, 2018 · b079601 · b079601
1 parent c09b098
commit b079601
Showing 1 changed file with 7 additions and 11 deletions.
diff --git a/x-pack/plugins/security/public/views/management/roles.html b/x-pack/plugins/security/public/views/management/roles.html
@@ -75,23 +75,19 @@
         </div>
 
         <!-- NoResults -->
-        <div class="kuiPanel kuiPanel--centered" ng-show="!(roles | filter:query).length">
+        <div class="kuiPanel kuiPanel--centered" ng-if="!(roles | filter:query).length">
           <div
             class="kuiNoItems"
           >
             <span
-              i18n-id="xpack.security.management.roles.noFoundMatchingRolesDescription1"
-              i18n-default-message="No "
-              i18n-context="Part of composite label xpack.security.management.roles.noFoundMatchingRolesDescription1 + {matchingText} + xpack.security.management.roles.noFoundMatchingRolesDescription2"
+              ng-if="query"
+              i18n-id="xpack.security.management.roles.noMatchingResultsLabel"
+              i18n-default-message="No matching roles found"
             ></span>
             <span
-              ng-show="query"
-              i18n-id="xpack.security.management.roles.matchingText"
-              i18n-default-message="matching"
-            ></span>
-            <span
-              i18n-id="xpack.security.management.roles.noFoundMatchingRolesDescription2"
-              i18n-default-message=" roles found"
+              ng-if="!query"
+              i18n-id="xpack.security.management.roles.noResultsLabel"
+              i18n-default-message="No roles found"
             ></span>
           </div>
         </div>