Skip to content

Commit

Permalink
Migrate more tests
Browse files Browse the repository at this point in the history
  • Loading branch information
kertal committed Mar 10, 2020
1 parent 5453980 commit b503c56
Show file tree
Hide file tree
Showing 4 changed files with 79 additions and 203 deletions.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ import {
FilterManager,
IndexPatternsContract,
} from '../../../../../../../../../plugins/data/public';
import { coreMock } from '../../../../../../../../../core/public/mocks';
const setupMock = coreMock.createSetup();

let state: {
queryParameters: {
defaultStepSize: number;
Expand All @@ -33,22 +36,11 @@ let state: {
};
let filterManager: FilterManager;
let indexPatterns: IndexPatternsContract;
let filterManagerSpy: jest.SpyInstance;

beforeEach(() => {
indexPatterns = {
get: () => {
return {
popularizeField: jest.fn(),
};
},
} as IndexPatternsContract;

filterManager = {
filters: [],
addFilters: jest.fn(),
setFilters: jest.fn(),
getAppFilters: () => [],
} as FilterManager;
filterManager = new FilterManager(setupMock.uiSettings);
filterManagerSpy = jest.spyOn(filterManager, 'addFilters');

state = {
queryParameters: {
Expand All @@ -63,42 +55,107 @@ beforeEach(() => {
describe('context query_parameter actions', function() {
describe('action addFilter', () => {
it('should pass the given arguments to the filterManager', () => {
const { addFilter } = getQueryParameterActions(filterManager, indexPatterns);
const { addFilter } = getQueryParameterActions(filterManager);

addFilter(state)('FIELD_NAME', 'FIELD_VALUE', 'FILTER_OPERATION');

// get the generated filter
const generatedFilter = filterManager.addFilters.mock.calls[0][0][0];
const generatedFilter = filterManagerSpy.mock.calls[0][0][0];
const queryKeys = Object.keys(generatedFilter.query.match_phrase);
expect(filterManager.addFilters.mock.calls.length).toBe(1);
expect(filterManagerSpy.mock.calls.length).toBe(1);
expect(queryKeys[0]).toBe('FIELD_NAME');
expect(generatedFilter.query.match_phrase[queryKeys[0]]).toBe('FIELD_VALUE');
});

it('should pass the index pattern id to the filterManager', () => {
const { addFilter } = getQueryParameterActions(filterManager, indexPatterns);
const { addFilter } = getQueryParameterActions(filterManager);
addFilter(state)('FIELD_NAME', 'FIELD_VALUE', 'FILTER_OPERATION');
const generatedFilter = filterManager.addFilters.mock.calls[0][0][0];
const generatedFilter = filterManagerSpy.mock.calls[0][0][0];
expect(generatedFilter.meta.index).toBe('INDEX_PATTERN_ID');
});
});
describe('action setPredecessorCount', () => {
it('should set the predecessorCount to the given value', () => {
const { setPredecessorCount } = getQueryParameterActions(indexPatterns, filterManager);
const { setPredecessorCount } = getQueryParameterActions(filterManager);
setPredecessorCount(state)(20);
expect(state.queryParameters.predecessorCount).toBe(20);
});

it('should limit the predecessorCount to 0 as a lower bound', () => {
const { setPredecessorCount } = getQueryParameterActions(indexPatterns, filterManager);
const { setPredecessorCount } = getQueryParameterActions(indexPatterns);
setPredecessorCount(state)(-1);
expect(state.queryParameters.predecessorCount).toBe(0);
});

it('should limit the predecessorCount to 10000 as an upper bound', () => {
const { setPredecessorCount } = getQueryParameterActions(indexPatterns, filterManager);
const { setPredecessorCount } = getQueryParameterActions(indexPatterns);
setPredecessorCount(state)(20000);
expect(state.queryParameters.predecessorCount).toBe(10000);
});
});
describe('action setSuccessorCount', () => {
it('should set the successorCount to the given value', function() {
const { setSuccessorCount } = getQueryParameterActions(filterManager);
setSuccessorCount(state)(20);

expect(state.queryParameters.successorCount).toBe(20);
});

it('should limit the successorCount to 0 as a lower bound', () => {
const { setSuccessorCount } = getQueryParameterActions(filterManager);
setSuccessorCount(state)(-1);
expect(state.queryParameters.successorCount).toBe(0);
});

it('should limit the successorCount to 10000 as an upper bound', () => {
const { setSuccessorCount } = getQueryParameterActions(filterManager);
setSuccessorCount(state)(20000);
expect(state.queryParameters.successorCount).toBe(10000);
});
});
describe('action setQueryParameters', function() {
const { setQueryParameters } = getQueryParameterActions(filterManager);

it('should update the queryParameters with valid properties from the given object', function() {
const newState = {
...state,
queryParameters: {
additionalParameter: 'ADDITIONAL_PARAMETER',
},
};

const actualState = setQueryParameters(newState)({
anchorId: 'ANCHOR_ID',
columns: ['column'],
defaultStepSize: 3,
filters: ['filter'],
indexPatternId: 'INDEX_PATTERN',
predecessorCount: 100,
successorCount: 100,
sort: ['field'],
});

expect(actualState).toEqual({
additionalParameter: 'ADDITIONAL_PARAMETER',
anchorId: 'ANCHOR_ID',
columns: ['column'],
defaultStepSize: 3,
filters: ['filter'],
indexPatternId: 'INDEX_PATTERN',
predecessorCount: 100,
successorCount: 100,
sort: ['field'],
});
});

it('should ignore invalid properties', function() {
const newState = { ...state };

setQueryParameters(newState)({
additionalParameter: 'ADDITIONAL_PARAMETER',
});

expect(state.queryParameters).toEqual(newState.queryParameters);
});
});
});

0 comments on commit b503c56

Please sign in to comment.