Skip to content

Commit

Permalink
Remove unused field (#194084)
Browse files Browse the repository at this point in the history
## Summary

The API
[model](https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/common/types/rest_spec/package_policy.ts#L48)
(points
[here](https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/common/types/rest_spec/package_policy.ts#L40-L42))
doesn't actually define this field and it's not returned by the server.

Related to
elastic/terraform-provider-elasticstack#787 (comment)


### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <[email protected]>
  • Loading branch information
tobio and kibanamachine authored Sep 26, 2024
1 parent 2217337 commit be9dd06
Show file tree
Hide file tree
Showing 7 changed files with 2 additions and 24 deletions.
3 changes: 0 additions & 3 deletions oas_docs/output/kibana.serverless.staging.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13012,11 +13012,8 @@ paths:
properties:
item:
$ref: '#/components/schemas/Fleet_package_policy'
sucess:
type: boolean
required:
- item
- sucess
description: OK
'400':
$ref: '#/components/responses/Fleet_error'
Expand Down
3 changes: 0 additions & 3 deletions oas_docs/output/kibana.serverless.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9123,11 +9123,8 @@ paths:
properties:
item:
$ref: '#/components/schemas/Fleet_package_policy'
sucess:
type: boolean
required:
- item
- sucess
description: OK
'400':
$ref: '#/components/responses/Fleet_error'
Expand Down
3 changes: 0 additions & 3 deletions oas_docs/output/kibana.staging.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16440,11 +16440,8 @@ paths:
properties:
item:
$ref: '#/components/schemas/Fleet_package_policy'
sucess:
type: boolean
required:
- item
- sucess
description: OK
'400':
$ref: '#/components/responses/Fleet_error'
Expand Down
3 changes: 0 additions & 3 deletions oas_docs/output/kibana.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11734,11 +11734,8 @@ paths:
properties:
item:
$ref: '#/components/schemas/Fleet_package_policy'
sucess:
type: boolean
required:
- item
- sucess
description: OK
'400':
$ref: '#/components/responses/Fleet_error'
Expand Down
8 changes: 2 additions & 6 deletions x-pack/plugins/fleet/common/openapi/bundled.json
Original file line number Diff line number Diff line change
Expand Up @@ -4728,14 +4728,10 @@
"properties": {
"item": {
"$ref": "#/components/schemas/package_policy"
},
"sucess": {
"type": "boolean"
}
},
"required": [
"item",
"sucess"
"item"
]
}
}
Expand Down Expand Up @@ -9567,4 +9563,4 @@
"basicAuth": []
}
]
}
}
3 changes: 0 additions & 3 deletions x-pack/plugins/fleet/common/openapi/bundled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2938,11 +2938,8 @@ paths:
properties:
item:
$ref: '#/components/schemas/package_policy'
sucess:
type: boolean
required:
- item
- sucess
'400':
$ref: '#/components/responses/error'
parameters:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,8 @@ put:
properties:
item:
$ref: ../components/schemas/package_policy.yaml
sucess:
type: boolean
required:
- item
- sucess
'400':
$ref: ../components/responses/error.yaml
parameters:
Expand Down

0 comments on commit be9dd06

Please sign in to comment.