Add icons to the SO results

elastic · Nov 18, 2020 · bee03aa · bee03aa
1 parent 47cd1e1
commit bee03aa
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/x-pack/plugins/global_search_bar/public/components/search_bar.tsx b/x-pack/plugins/global_search_bar/public/components/search_bar.tsx
@@ -76,13 +76,10 @@ const resultToOption = (result: GlobalSearchResult): EuiSelectableTemplateSitewi
     label: title,
     url,
     type,
+    icon: { type: icon ?? 'empty' },
     'data-test-subj': `nav-search-option`,
   };
 
-  if (icon) {
-    option.icon = { type: icon };
-  }
-
   if (type === 'application') {
     option.meta = [{ text: meta?.categoryLabel as string }];
   } else {

diff --git a/...ugins/global_search_providers/server/providers/saved_objects/map_object_to_result.test.ts b/...ugins/global_search_providers/server/providers/saved_objects/map_object_to_result.test.ts
@@ -42,6 +42,7 @@ describe('mapToResult', () => {
       name: 'dashboard',
       management: {
         defaultSearchField: 'title',
+        icon: 'dashboardApp',
         getInAppUrl: (obj) => ({ path: `/dashboard/${obj.id}`, uiCapabilitiesPath: '' }),
       },
     });
@@ -62,6 +63,7 @@ describe('mapToResult', () => {
       title: 'My dashboard',
       type: 'dashboard',
       url: '/dashboard/dash1',
+      icon: 'dashboardApp',
       score: 42,
     });
   });

diff --git a/...ck/plugins/global_search_providers/server/providers/saved_objects/map_object_to_result.ts b/...ck/plugins/global_search_providers/server/providers/saved_objects/map_object_to_result.ts
@@ -50,6 +50,7 @@ export const mapToResult = (
     // so we are forced to cast the attributes to any to access the properties associated with it.
     title: (object.attributes as any)[defaultSearchField],
     type: object.type,
+    icon: type.management?.icon ?? undefined,
     url: getInAppUrl(object).path,
     score: object.score,
   };