Skip to content

Commit

Permalink
[index pattern management] index pattern => data view for user facing…
Browse files Browse the repository at this point in the history
… content (#109577)

* index pattern => data view for user facing content
  • Loading branch information
mattkime authored Aug 24, 2021
1 parent 25cf47b commit d5faaf7
Show file tree
Hide file tree
Showing 12 changed files with 40 additions and 77 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ import { IndexPattern } from '../../../data/public';
export function getListBreadcrumbs() {
return [
{
text: i18n.translate('indexPatternManagement.indexPatterns.listBreadcrumb', {
defaultMessage: 'Index patterns',
text: i18n.translate('indexPatternManagement.dataViews.listBreadcrumb', {
defaultMessage: 'Data views',
}),
href: `/`,
},
Expand All @@ -24,8 +24,8 @@ export function getCreateBreadcrumbs() {
return [
...getListBreadcrumbs(),
{
text: i18n.translate('indexPatternManagement.indexPatterns.createBreadcrumb', {
defaultMessage: 'Create index pattern',
text: i18n.translate('indexPatternManagement.dataViews.createBreadcrumb', {
defaultMessage: 'Create data view',
}),
href: `/create`,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,11 @@ export const CreateEditField = withRouter(
const url = `/patterns/${indexPattern.id}`;

if (mode === 'edit' && !spec) {
const message = i18n.translate(
'indexPatternManagement.editIndexPattern.scripted.noFieldLabel',
{
defaultMessage:
"'{indexPatternTitle}' index pattern doesn't have a scripted field called '{fieldName}'",
values: { indexPatternTitle: indexPattern.title, fieldName },
}
);
const message = i18n.translate('indexPatternManagement.editDataView.scripted.noFieldLabel', {
defaultMessage:
"'{dataViewTitle}' data view doesn't have a scripted field called '{fieldName}'",
values: { dataViewTitle: indexPattern.title, fieldName },
});
notifications.toasts.addWarning(message);
history.push(url);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ const confirmModalOptionsDelete = {
confirmButtonText: i18n.translate('indexPatternManagement.editIndexPattern.deleteButton', {
defaultMessage: 'Delete',
}),
title: i18n.translate('indexPatternManagement.editIndexPattern.deleteHeader', {
defaultMessage: 'Delete index pattern?',
title: i18n.translate('indexPatternManagement.editDataView.deleteHeader', {
defaultMessage: 'Delete data view?',
}),
};

Expand Down Expand Up @@ -129,8 +129,8 @@ export const EditIndexPattern = withRouter(
}
);

const headingAriaLabel = i18n.translate('indexPatternManagement.editIndexPattern.detailsAria', {
defaultMessage: 'Index pattern details',
const headingAriaLabel = i18n.translate('indexPatternManagement.editDataView.detailsAria', {
defaultMessage: 'Data view details',
});

chrome.docTitle.change(indexPattern.title);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,26 +18,20 @@ interface IndexHeaderProps {
deleteIndexPatternClick?: () => void;
}

const setDefaultAriaLabel = i18n.translate(
'indexPatternManagement.editIndexPattern.setDefaultAria',
{
defaultMessage: 'Set as default index.',
}
);
const setDefaultAriaLabel = i18n.translate('indexPatternManagement.editDataView.setDefaultAria', {
defaultMessage: 'Set as default data view.',
});

const setDefaultTooltip = i18n.translate(
'indexPatternManagement.editIndexPattern.setDefaultTooltip',
{
defaultMessage: 'Set as default index.',
}
);
const setDefaultTooltip = i18n.translate('indexPatternManagement.editDataView.setDefaultTooltip', {
defaultMessage: 'Set as default data view.',
});

const removeAriaLabel = i18n.translate('indexPatternManagement.editIndexPattern.removeAria', {
defaultMessage: 'Remove index pattern.',
const removeAriaLabel = i18n.translate('indexPatternManagement.editDataView.removeAria', {
defaultMessage: 'Remove data view.',
});

const removeTooltip = i18n.translate('indexPatternManagement.editIndexPattern.removeTooltip', {
defaultMessage: 'Remove index pattern.',
const removeTooltip = i18n.translate('indexPatternManagement.editDataView.removeTooltip', {
defaultMessage: 'Remove data view.',
});

export const IndexHeader: React.FC<IndexHeaderProps> = ({
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,8 @@ const runtimeIconTipTitle = i18n.translate(
);

const runtimeIconTipText = i18n.translate(
'indexPatternManagement.editIndexPattern.fields.table.runtimeIconTipText',
{ defaultMessage: 'This field exists on the index pattern only.' }
'indexPatternManagement.editDataView.fields.table.runtimeIconTipText',
{ defaultMessage: 'This field exists on the data view only.' }
);

interface IndexedFieldProps {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ const search = {
},
};

const title = i18n.translate('indexPatternManagement.indexPatternTable.title', {
defaultMessage: 'Index patterns',
const title = i18n.translate('indexPatternManagement.dataViewTable.title', {
defaultMessage: 'Data views',
});

interface Props extends RouteComponentProps {
Expand Down Expand Up @@ -97,7 +97,9 @@ export const IndexPatternTable = ({
const columns = [
{
field: 'title',
name: 'Pattern',
name: i18n.translate('indexPatternManagement.dataViewTable.nameColumn', {
defaultMessage: 'Name',
}),
render: (
name: string,
index: {
Expand Down Expand Up @@ -134,8 +136,8 @@ export const IndexPatternTable = ({
data-test-subj="createIndexPatternButton"
>
<FormattedMessage
id="indexPatternManagement.indexPatternTable.createBtn"
defaultMessage="Create index pattern"
id="indexPatternManagement.dataViewTable.createBtn"
defaultMessage="Create data view"
/>
</EuiButton>
) : (
Expand Down Expand Up @@ -164,8 +166,8 @@ export const IndexPatternTable = ({
pageTitle={title}
description={
<FormattedMessage
id="indexPatternManagement.indexPatternTable.indexPatternExplanation"
defaultMessage="Create and manage the index patterns that help you retrieve your data from Elasticsearch."
id="indexPatternManagement.dataViewTable.indexPatternExplanation"
defaultMessage="Create and manage the data views that help you retrieve your data from Elasticsearch."
/>
}
bottomBorder
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ const readOnlyBadge = {
text: i18n.translate('indexPatternManagement.indexPatterns.badge.readOnly.text', {
defaultMessage: 'Read only',
}),
tooltip: i18n.translate('indexPatternManagement.indexPatterns.badge.readOnly.tooltip', {
defaultMessage: 'Unable to save index patterns',
tooltip: i18n.translate('indexPatternManagement.dataViews.badge.readOnly.tooltip', {
defaultMessage: 'Unable to save data views',
}),
iconType: 'glasses',
};
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/index_pattern_management/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ export interface IndexPatternManagementSetup {}
// eslint-disable-next-line @typescript-eslint/no-empty-interface
export interface IndexPatternManagementStart {}

const sectionsHeader = i18n.translate('indexPatternManagement.indexPattern.sectionsHeader', {
defaultMessage: 'Index Patterns',
const sectionsHeader = i18n.translate('indexPatternManagement.dataView.sectionsHeader', {
defaultMessage: 'Data Views',
});

const IPM_APP_ID = 'indexPatterns';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ export default function ({ getService, getPageObjects }) {

describe('index pattern deletion', function indexDelete() {
before(function () {
const expectedAlertText = 'Delete index pattern?';
const expectedAlertText = 'Delete data view?';
return PageObjects.settings.removeIndexPattern().then(function (alertText) {
expect(alertText).to.be(expectedAlertText);
});
Expand Down
15 changes: 0 additions & 15 deletions x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -2889,9 +2889,7 @@
"indexPatternManagement.disabledCallOutLabel": "Elasticsearchでのすべてのインラインスクリプティングが無効になっています。Kibanaでスクリプトフィールドを使用するには、インラインスクリプティングを有効にする必要があります。",
"indexPatternManagement.editHeader": "{fieldName}を編集",
"indexPatternManagement.editIndexPattern.deleteButton": "削除",
"indexPatternManagement.editIndexPattern.deleteHeader": "インデックスパターンを削除しますか?",
"indexPatternManagement.editIndexPattern.deprecation": "スクリプトフィールドは廃止予定です。代わりに{runtimeDocs}を使用してください。",
"indexPatternManagement.editIndexPattern.detailsAria": "インデックスパターンの詳細",
"indexPatternManagement.editIndexPattern.fields.addFieldButtonLabel": "フィールドの追加",
"indexPatternManagement.editIndexPattern.fields.allLangsDropDown": "すべての言語",
"indexPatternManagement.editIndexPattern.fields.allTypesDropDown": "すべてのフィールドタイプ",
Expand All @@ -2917,15 +2915,12 @@
"indexPatternManagement.editIndexPattern.fields.table.nameHeader": "名前",
"indexPatternManagement.editIndexPattern.fields.table.primaryTimeAriaLabel": "プライマリ時間フィールド",
"indexPatternManagement.editIndexPattern.fields.table.primaryTimeTooltip": "このフィールドはイベントの発生時刻を表します。",
"indexPatternManagement.editIndexPattern.fields.table.runtimeIconTipText": "このフィールドはインデックスパターンにのみ存在します。",
"indexPatternManagement.editIndexPattern.fields.table.runtimeIconTipTitle": "ランタイムフィールド",
"indexPatternManagement.editIndexPattern.fields.table.searchableDescription": "これらのフィールドはフィルターバーで使用できます",
"indexPatternManagement.editIndexPattern.fields.table.searchableHeader": "検索可能",
"indexPatternManagement.editIndexPattern.fields.table.typeHeader": "型",
"indexPatternManagement.editIndexPattern.list.defaultIndexPatternListName": "デフォルト",
"indexPatternManagement.editIndexPattern.mappingConflictHeader": "マッピングの矛盾",
"indexPatternManagement.editIndexPattern.removeAria": "インデックスパターンを削除します。",
"indexPatternManagement.editIndexPattern.removeTooltip": "インデックスパターンを削除します。",
"indexPatternManagement.editIndexPattern.scripted.addFieldButton": "スクリプトフィールドを追加",
"indexPatternManagement.editIndexPattern.scripted.deleteField.cancelButton": "キャンセル",
"indexPatternManagement.editIndexPattern.scripted.deleteField.deleteButton": "削除",
Expand All @@ -2934,7 +2929,6 @@
"indexPatternManagement.editIndexPattern.scripted.deprecationLangLabel.deprecationLangDetail": "次の廃止された言語が使用されています。{deprecatedLangsInUse}これらの言語は、KibanaとElasticsearchの次のメジャーバージョンでサポートされなくなります。問題を避けるため、スクリプトフィールドを{link}に変換してください。",
"indexPatternManagement.editIndexPattern.scripted.deprecationLangLabel.painlessDescription": "Painless",
"indexPatternManagement.editIndexPattern.scripted.newFieldPlaceholder": "新規スクリプトフィールド",
"indexPatternManagement.editIndexPattern.scripted.noFieldLabel": "「{indexPatternTitle}」インデックスパターンには「{fieldName}」というスクリプトフィールドがありません",
"indexPatternManagement.editIndexPattern.scripted.table.deleteDescription": "このフィールドを削除します",
"indexPatternManagement.editIndexPattern.scripted.table.deleteHeader": "削除",
"indexPatternManagement.editIndexPattern.scripted.table.editDescription": "このフィールドを編集します",
Expand All @@ -2948,8 +2942,6 @@
"indexPatternManagement.editIndexPattern.scripted.table.scriptDescription": "フィールドのスクリプトです",
"indexPatternManagement.editIndexPattern.scripted.table.scriptHeader": "スクリプト",
"indexPatternManagement.editIndexPattern.scriptedLabel": "スクリプトフィールドはビジュアライゼーションで使用され、ドキュメントに表示できます。ただし、検索することはできません。",
"indexPatternManagement.editIndexPattern.setDefaultAria": "デフォルトのインデックスに設定します。",
"indexPatternManagement.editIndexPattern.setDefaultTooltip": "デフォルトのインデックスに設定します。",
"indexPatternManagement.editIndexPattern.source.addButtonLabel": "追加",
"indexPatternManagement.editIndexPattern.source.deleteFilter.cancelButtonLabel": "キャンセル",
"indexPatternManagement.editIndexPattern.source.deleteFilter.deleteButtonLabel": "削除",
Expand Down Expand Up @@ -2977,15 +2969,8 @@
"indexPatternManagement.formatLabel": "フォーマットは、特定の値の表示形式を管理できます。また、値を完全に変更したり、Discover でのハイライト機能を無効にしたりすることも可能です。",
"indexPatternManagement.header.runtimeLink": "ランタイムフィールド",
"indexPatternManagement.indexNameLabel": "インデックス名",
"indexPatternManagement.indexPattern.sectionsHeader": "インデックスパターン",
"indexPatternManagement.indexPatterns.badge.readOnly.text": "読み取り専用",
"indexPatternManagement.indexPatterns.badge.readOnly.tooltip": "インデックスパターンを保存できません",
"indexPatternManagement.indexPatterns.createBreadcrumb": "インデックスパターンを作成",
"indexPatternManagement.indexPatterns.createFieldBreadcrumb": "フィールドを作成",
"indexPatternManagement.indexPatterns.listBreadcrumb": "インデックスパターン",
"indexPatternManagement.indexPatternTable.createBtn": "インデックスパターンを作成",
"indexPatternManagement.indexPatternTable.indexPatternExplanation": "Elasticsearchからのデータの取得に役立つインデックスパターンを作成して管理します。",
"indexPatternManagement.indexPatternTable.title": "インデックスパターン",
"indexPatternManagement.labelHelpText": "このフィールドが Discover、Maps、Visualize に表示されるときに使用するカスタムラベルを設定します。現在、クエリとフィルターはカスタムラベルをサポートせず、元のフィールド名が使用されます。",
"indexPatternManagement.languageLabel": "言語",
"indexPatternManagement.mappingConflictLabel.mappingConflictDetail": "{mappingConflict} {fieldName}というフィールドはすでに存在します。スクリプトフィールドに同じ名前を付けると、同時に両方のフィールドにクエリが実行できなくなります。",
Expand Down
Loading

0 comments on commit d5faaf7

Please sign in to comment.