removes logs and fixes if statement ordering

elastic · Jul 16, 2020 · daf8bbb · daf8bbb
1 parent 0be924c
commit daf8bbb
Showing 1 changed file with 8 additions and 11 deletions.
diff --git a/...plugins/security_solution/server/lib/detection_engine/signals/search_after_bulk_create.ts b/...plugins/security_solution/server/lib/detection_engine/signals/search_after_bulk_create.ts
@@ -234,22 +234,19 @@ export const searchAfterAndBulkCreate = async ({
           logger.debug(
             buildRuleMessage(`filteredEvents.hits.hits: ${filteredEvents.hits.hits.length}`)
           );
+
           if (
-            filteredEvents.hits.hits[0].sort == null ||
-            filteredEvents.hits.hits[0].sort.length === 0
-          ) {
-            logger.debug('\n\n\nBREAKING HERE 3\n\n\n');
-            logger.debug(buildRuleMessage('sortIds was empty on filter'));
-            toReturn.success = true;
-            break;
-          } else if (
-            filteredEvents.hits.hits !== null &&
-            filteredEvents.hits.hits[0].sort !== null
+            filteredEvents.hits.hits != null &&
+            filteredEvents.hits.hits[0].sort != null &&
+            filteredEvents.hits.hits[0].sort.length !== 0
           ) {
-            logger.debug('SETTING SORT ID HERE');
             sortId = filteredEvents.hits.hits[0].sort
               ? filteredEvents.hits.hits[0].sort[0]
               : undefined;
+          } else {
+            logger.debug(buildRuleMessage('sortIds was empty on search'));
+            toReturn.success = true;
+            break;
           }
         } else {
           // we are guaranteed to have searchResult hits at this point