Merge branch '7.5' into backport/7.5/pr-47861

elastic · Oct 31, 2019 · e2ac3c8 · e2ac3c8
2 parents 4ab7e0a + 5d6cf13
commit e2ac3c8
Show file tree

Hide file tree

Showing 68 changed files with 1,051 additions and 430 deletions.
diff --git a/docs/CHANGELOG.asciidoc b/docs/CHANGELOG.asciidoc
@@ -10,6 +10,7 @@
 
 This section summarizes the changes in each release.
 
+* <<release-notes-7.4.2>>
 * <<release-notes-7.4.1>>
 * <<release-notes-7.4.0>>
 * <<release-notes-7.3.2>>
@@ -28,6 +29,22 @@ This section summarizes the changes in each release.
 * <<release-notes-7.0.0-alpha1>>
 
 --
+
+[[release-notes-7.4.2]]
+== {kib} 7.4.2
+
+Also see <<breaking-changes-7.4, breaking changes in 7.4>>.
+
+[float]
+[[bug-7.4.2]]
+=== Bug fix
+Discover::
+* Fixes missing HTML formatting in Doc_Viewer {pull}49326[#49326]
+* Fixes the URL field formatter {pull}46332[#46332]
+Visualizations::
+* Fixes the loss of filters in TSVB after upgrade from 7.2 to 7.3 {pull}48710[#48710]
+
+
 [[release-notes-7.4.1]]
 == {kib} 7.4.1
 

diff --git a/docs/canvas/canvas-expressions.asciidoc b/docs/canvas/canvas-expressions.asciidoc
diff --git a/docs/canvas/canvas-share-workpad.asciidoc b/docs/canvas/canvas-share-workpad.asciidoc
@@ -2,47 +2,100 @@
 [[workpad-share-options]]
 == Share your workpad
 
-When you are ready to share your workpad, create a PDF, or export your workpad.
+When you've finished your workpad, you can share it outside of {kib}.
+
+[float]
+[[export-single-workpad]]
+=== Export workpads
+
+Create a JSON file of your workpad that you can export outside of {kib}.
+
+. From your workpad, click the *Share workpad* icon in the upper left corner.
+
+. Select *Download as JSON*.
++
+[role="screenshot"]
+image::images/canvas-export-workpad.png[Export single workpad]
+
+Want to export multiple workpads? Go to the *Canvas workpads* view, select the workpads you want to export, then click *Export*.
 
 [float]
 [[create-workpad-pdf]]
 === Create a PDF
 
-To view your workpad outside of Kibana, generate a PDF. 
+Create a PDF copy of your workpad that you can save and share outside of {kib}.
 
 . If you are using a Gold or Platinum license, enable reporting in your `config/kibana.yml` file.
 
 . From your workpad, click the *Share workpad* icon in the upper left corner, then select *PDF reports*.
 
-. Click *Generate PDF*. 
+. Click *Generate PDF*.
 +
 [role="screenshot"]
 image::images/canvas-generate-pdf.gif[Generate PDF]
 
 [float]
-[[export-workpad]]
-=== Export your workpad
+[[create-workpad-URL]]
+=== Create a POST URL
+
+Create a POST URL that you can use to automatically generate PDF reports using Watcher or a script.
+
+For more information, refer to <<automating-report-generation, Automating report generation>>.
+
+. If you are using a Gold or Platinum license, enable reporting in your `config/kibana.yml` file.
+
+. From your workpad, click the *Share workpad* icon in the upper left corner, then select *PDF reports*.
 
-To share your workpad with another author, export it as a JSON file.
+. Click *Copy POST URL*.
++
+[role="screenshot"]
+image::images/canvas-create-URL.gif[Create POST URL]
 
 [float]
-[[export-single-workpad]]
-==== Export a single workpad
+[[add-workpad-website]]
+=== Share the workpad on a website
 
-. From your workpad, click the *Share workpad* icon in the upper left corner.
+beta[] Download the workpad and share it on any website, then customize the workpad behavior to autoplay the pages or hide the toolbar.
 
-. Select *Download as JSON*.
+. If you are using a Gold or Platinum license, enable reporting in your `config/kibana.yml` file.
+
+. From your workpad, click the *Share this workpad* icon in the upper left corner, then select *Share on a website*.
+
+. On the *Share on a website* pane, follow the instructions.
+
+. To customize the workpad behavior to autoplay the pages or hide the toolbar, use the inline parameters.
++
+To make sure that your data remains secure, the data in the JSON file is not connected to {kib}. Canvas does not display elements that manipulate the data on the workpad.
 +
 [role="screenshot"]
-image::images/canvas-export-workpad.png[Export single workpad]
+image::images/canvas-embed_workpad.gif[Share the workpad on a website]
++
+NOTE: Shareable workpads encode the current state of the workpad in a JSON file. When you make changes to the workpad, the changes do not appear in the shareable workpad on your website.
 
 [float]
-[[export-multiple-workpads]]
-==== Export multiple workpads
+[[change-the-workpad-settings]]
+=== Change the shareable workpad settings
 
-. Go to the *Canvas workpads* page.
+After you've added the workpad to your website, you can change the autoplay and toolbar settings.
 
-. Select the workpads you want to export
+[float]
+[[shareable-workpad-enable-autoplay]]
+==== Change the autoplay settings
 
-. Click *Export*.
+. In the lower right corner of the shareable workpad, click the settings icon.
 
+. Click *Auto Play*, then change the settings.
++
+[role="screenshot"]
+image::images/canvas_share_autoplay_480.gif[Autoplay settings]
+
+[float]
+[[hide-workpad-toolbar]]
+==== Change the toolbar settings
+
+. In the lower right corner, click the settings icon.
+
+. Click *Toolbar*, then change the settings.
++
+[role="screenshot"]
+image::images/canvas_share_hidetoolbar_480.gif[Hide toolbar settings]
diff --git a/docs/canvas/canvas-workpad.asciidoc b/docs/canvas/canvas-workpad.asciidoc
@@ -18,17 +18,17 @@ To create a workpad, you can:
 [[blank-canvas-workpad]]
 === Start with a blank page
 
-To use the background colors, images, and data of your choice, start with a blank workpad. 
+To use the background colors, images, and data of your choice, start with a blank workpad.
 
 . Open *Canvas*.
 
-. On the *Canvas workpads* page, click *Create workpad*.
+. On the *Canvas workpads* view, click *Create workpad*.
 
 . Add a *Name* to your workpad.
 
-. In the *Width* and *Height* fields, specify the size. 
+. In the *Width* and *Height* fields, specify the size.
 
-. Select the layout. 
+. Select the layout.
 +
 For example, click *720p* for a traditional presentation layout.
 
@@ -45,7 +45,7 @@ If you're unsure about where to start, you can use one of the preconfigured temp
 
 . Open *Canvas*.
 
-. On the *Canvas workpads* page, select *Templates*.
+. On the *Canvas workpads* view, select *Templates*.
 
 . Click the preconfigured template that you want to use.
 
@@ -59,19 +59,19 @@ When you want to use a workpad that someone else has already started, import the
 
 . Open *Canvas*.
 
-. On the *Canvas workpads* page, click and drag the file to the *Import workpad JSON file* field.
+. On the *Canvas workpads* view, click and drag the file to the *Import workpad JSON file* field.
 
 [float]
 [[sample-data-workpad]]
 === Use a sample data workpad
 
 Each of the sample data sets comes with a Canvas workpad that you can use for your own workpad inspiration.
 
-. Add a {kibana-ref}/add-sample-data.html[sample data set]. 
+. Add a {kibana-ref}/add-sample-data.html[sample data set].
 
 . On the *Add Data to Kibana* page, click the *View data* dropdown list, then select *Canvas*.
 +
-Need some more workpad inspiration? Check out the link:https://www.elastic.co/blog/[Elastic Blog]. 
+Need some more workpad inspiration? Check out the link:https://www.elastic.co/blog/[Elastic Blog].
 
 [float]
 [[apply-workpad-styles]]

diff --git a/docs/images/canvas-create-URL.gif b/docs/images/canvas-create-URL.gif
diff --git a/docs/images/canvas-embed_workpad.gif b/docs/images/canvas-embed_workpad.gif
diff --git a/docs/images/canvas-export-workpad.png b/docs/images/canvas-export-workpad.png
diff --git a/docs/images/canvas-generate-pdf.gif b/docs/images/canvas-generate-pdf.gif
diff --git a/docs/images/canvas_share_autoplay_480.gif b/docs/images/canvas_share_autoplay_480.gif
diff --git a/docs/images/canvas_share_hidetoolbar_480.gif b/docs/images/canvas_share_hidetoolbar_480.gif
diff --git a/docs/user/canvas.asciidoc b/docs/user/canvas.asciidoc
@@ -5,15 +5,15 @@
 [partintro]
 --
 
-Canvas is a data visualization and presentation tool that sits within Kibana. With Canvas, you can pull live data directly from Elasticsearch, and combine the data with colors, images, text, and your imagination to create dynamic, multi-page, pixel-perfect displays. If you are a little bit creative, a little bit technical, and a whole lot curious, then Canvas is for you. 
+Canvas is a data visualization and presentation tool that sits within Kibana. With Canvas, you can pull live data directly from Elasticsearch, and combine the data with colors, images, text, and your imagination to create dynamic, multi-page, pixel-perfect displays. If you are a little bit creative, a little bit technical, and a whole lot curious, then Canvas is for you.
 
 With Canvas, you can:
 
-* Create and personalize your work space with backgrounds, borders, colors, fonts, and more. 
+* Create and personalize your work space with backgrounds, borders, colors, fonts, and more.
 
 * Customize your workpad with your own visualizations, such as images and text.
 
-* Customize your data by pulling it directly from Elasticsearch. 
+* Customize your data by pulling it directly from Elasticsearch.
 
 * Show off your data with charts, graphs, progress monitors, and more.
 
@@ -37,8 +37,6 @@ include::{kib-repo-dir}/canvas/canvas-present-workpad.asciidoc[]
 
 include::{kib-repo-dir}/canvas/canvas-share-workpad.asciidoc[]
 
-//include::{kib-repo-dir}/canvas/canvas-expressions.asciidoc[]
-
 include::{kib-repo-dir}/canvas/canvas-function-reference.asciidoc[]
 
 include::{kib-repo-dir}/canvas/canvas-tinymath-functions.asciidoc[]
diff --git a/docs/user/security/authentication/index.asciidoc b/docs/user/security/authentication/index.asciidoc
@@ -138,7 +138,7 @@ xpack.security.authc.saml.maxRedirectURLSize: 1kb
 ==== OpenID Connect Single Sign-On
 
 Similar to SAML, authentication with OpenID Connect allows users to log in to {kib} using an OpenID Connect Provider such as Google, or Okta. OpenID Connect
-should also be configured in {es}, see {xpack-ref}/saml-guide.html[Configuring OpenID Connect Single-Sign-On on the Elastic Stack] for more details.
+should also be configured in {es}. For more details, see {ref}/oidc-guide.html[Configuring single sign-on to the {stack} using OpenID Connect].
 
 Set the configuration values in `kibana.yml` as follows:
 

diff --git a/src/legacy/core_plugins/kibana/public/discover/index.html b/src/legacy/core_plugins/kibana/public/discover/index.html
@@ -170,6 +170,7 @@ <h1 class="euiScreenReaderOnly">{{screenTitle}}</h1>
                 chart-data="histogramData"
                 timefilter-update-handler="timefilterUpdateHandler"
                 watch-depth="reference"
+                data-test-subj="discoverChart"
               ></discover-histogram>
             </section>
 

diff --git a/src/legacy/core_plugins/kibana/public/index.scss b/src/legacy/core_plugins/kibana/public/index.scss
@@ -36,10 +36,3 @@
 // Dashboard styles
 // MUST STAY AT THE BOTTOM BECAUSE OF DARK THEME IMPORTS
 @import './dashboard/index';
-
-// helper class that hides elements when rendered in percy
-@media only percy {
-  .hideInPercy {
-    visibility: hidden;
-  }
-}
diff --git a/test/api_integration/apis/index_patterns/fields_for_wildcard_route/params.js b/test/api_integration/apis/index_patterns/fields_for_wildcard_route/params.js
@@ -20,7 +20,7 @@
 export default function ({ getService }) {
   const esArchiver = getService('esArchiver');
   const supertest = getService('supertest');
-  const chance = getService('chance');
+  const randomness = getService('randomness');
 
   describe('params', () => {
     before(() => esArchiver.load('index_patterns/basic_index'));
@@ -63,8 +63,8 @@ export default function ({ getService }) {
       supertest
         .get('/api/index_patterns/_fields_for_wildcard')
         .query({
-          pattern: chance.word(),
-          [chance.word()]: chance.word(),
+          pattern: randomness.word(),
+          [randomness.word()]: randomness.word(),
         })
         .expect(400));
   });

diff --git a/test/api_integration/services/chance.js b/test/api_integration/services/chance.js
diff --git a/test/api_integration/services/index.ts b/test/api_integration/services/index.ts
@@ -22,14 +22,11 @@ import { services as commonServices } from '../../common/services';
 // @ts-ignore not TS yet
 import { KibanaSupertestProvider, ElasticsearchSupertestProvider } from './supertest';
 
-// @ts-ignore not TS yet
-import { ChanceProvider } from './chance';
-
 export const services = {
   es: commonServices.es,
   esArchiver: commonServices.esArchiver,
   retry: commonServices.retry,
   supertest: KibanaSupertestProvider,
   esSupertest: ElasticsearchSupertestProvider,
-  chance: ChanceProvider,
+  randomness: commonServices.randomness,
 };
diff --git a/test/common/services/index.ts b/test/common/services/index.ts
@@ -21,10 +21,12 @@ import { LegacyEsProvider } from './legacy_es';
 import { EsArchiverProvider } from './es_archiver';
 import { KibanaServerProvider } from './kibana_server';
 import { RetryProvider } from './retry';
+import { RandomnessProvider } from './randomness';
 
 export const services = {
   es: LegacyEsProvider,
   esArchiver: EsArchiverProvider,
   kibanaServer: KibanaServerProvider,
   retry: RetryProvider,
+  randomness: RandomnessProvider,
 };