Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Sparkline labels are overlaying on top of each other #109103

Closed
cauemarcondes opened this issue Aug 18, 2021 · 3 comments · Fixed by #109137
Closed

[APM] Sparkline labels are overlaying on top of each other #109103

cauemarcondes opened this issue Aug 18, 2021 · 3 comments · Fixed by #109137
Assignees
@dgieselaar
Labels
apm:test-plan-done Pull request that was successfully tested during the test plan apm:ux-refresh bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.15.0

Comments

@cauemarcondes
Copy link
Contributor

Screen Shot 2021-08-18 at 09.45.15.png
@cauemarcondes cauemarcondes added [zube]: 7.15 apm:ux-refresh bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.15.0 labels Aug 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes cauemarcondes changed the title [APM] Sparkline labels are on overlaying on top of each other [APM] Sparkline labels are overlaying on top of each other Aug 18, 2021
@formgeist
Copy link
Contributor

@cauemarcondes Yeah, noticed this too - I think the column size doesn't account for the increase SparkPlot size, so we need to increase the default column width of latency + throughput (failed transaction rate is fine) to 180px instead of 160px. That should solve it for most cases unless you have a more dynamic solution?

@smith smith self-assigned this Aug 18, 2021
smith added a commit to smith/kibana that referenced this issue Aug 18, 2021
@smith
Increase width of service inventory sparkplot columns
cd080ca 
From 160 to 176px. Prevents overlapping of the labels.

Fixes elastic#109103.
@smith smith mentioned this issue Aug 18, 2021
Merged
smith added a commit that referenced this issue Aug 19, 2021
@smith
Increase width of service inventory sparkplot columns (#109137)
09f122b 
From 160 to 176px. Prevents overlapping of the labels.

Fixes #109103.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Aug 19, 2021
@smith @kibanamachine
Increase width of service inventory sparkplot columns (elastic#109137)
df82ae7 
From 160 to 176px. Prevents overlapping of the labels.

Fixes elastic#109103.
kibanamachine added a commit that referenced this issue Aug 19, 2021
@kibanamachine @smith
Increase width of service inventory sparkplot columns (#109137) (#109193
d9c71d4 
)

From 160 to 176px. Prevents overlapping of the labels.

Fixes #109103.

Co-authored-by: Nathan L Smith <[email protected]>
@dgieselaar dgieselaar self-assigned this Aug 25, 2021
@dgieselaar dgieselaar added the apm:test-plan-done Pull request that was successfully tested during the test plan label Aug 25, 2021
@dgieselaar
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgieselaar dgieselaar

Labels
apm:test-plan-done Pull request that was successfully tested during the test plan apm:ux-refresh bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase width of service inventory sparkplot columns smith/kibana
6 participants
@smith @sorenlouv @dgieselaar @formgeist @elasticmachine @cauemarcondes