Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accessibility] Dark theme markdown visualization's "blockquote" element fails color contrast #12491

Closed
cjcenizal opened this issue Jun 24, 2017 · 1 comment · Fixed by #13507
Closed

[Accessibility] Dark theme markdown visualization's "blockquote" element fails color contrast #12491

cjcenizal opened this issue Jun 24, 2017 · 1 comment · Fixed by #13507
Assignees
@timroes
Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:Accessibility Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@cjcenizal
Copy link
Contributor

image

The foreground color is #666666 and the background color is #272727.
@cjcenizal cjcenizal added Project:Accessibility Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Jun 24, 2017
@cjcenizal
Copy link
Contributor Author

CC @snide

@cjcenizal cjcenizal mentioned this issue Jun 24, 2017
Closed
20 tasks
@tbragin tbragin added the bug Fixes for quality problems that affect the customer experience label Jul 28, 2017
@timroes timroes self-assigned this Aug 15, 2017
timroes pushed a commit to timroes/kibana that referenced this issue Aug 15, 2017
Fix contrast ratio of markdown blockquotes, elastic#12491
9558d73
@timroes timroes mentioned this issue Aug 15, 2017
Merged
timroes added a commit that referenced this issue Aug 18, 2017
@timroes
Improve accessibility of visualizations (#13507)
ef67957 
* Fix markdown vis settings labels

* Fix contrast ratio of markdown blockquotes, #12491

* Fix fontsize of blockquotes in markdown, #12904

* Add vis type description for screen reader, fix #12887

The way tooltips are currently implemented we unfortunately cannot use
the tooltip for the aria-describedby. This is another issue to solve.

* Make main nav a11y when collapsed

* Camel case the vistype id used in HTML
timroes added a commit that referenced this issue Aug 18, 2017
@timroes
Improve accessibility of visualizations (#13507)
eeff551 
* Fix markdown vis settings labels

* Fix contrast ratio of markdown blockquotes, #12491

* Fix fontsize of blockquotes in markdown, #12904

* Add vis type description for screen reader, fix #12887

The way tooltips are currently implemented we unfortunately cannot use
the tooltip for the aria-describedby. This is another issue to solve.

* Make main nav a11y when collapsed

* Camel case the vistype id used in HTML
timroes added a commit that referenced this issue Aug 18, 2017
@timroes
Improve accessibility of visualizations (#13507)
ff3a407 
* Fix markdown vis settings labels

* Fix contrast ratio of markdown blockquotes, #12491

* Fix fontsize of blockquotes in markdown, #12904

* Add vis type description for screen reader, fix #12887

The way tooltips are currently implemented we unfortunately cannot use
the tooltip for the aria-describedby. This is another issue to solve.

* Make main nav a11y when collapsed

* Camel case the vistype id used in HTML
chrisronline pushed a commit to chrisronline/kibana that referenced this issue Nov 20, 2017
@timroes @chrisronline
Improve accessibility of visualizations (elastic#13507)
1dcf072 
* Fix markdown vis settings labels

* Fix contrast ratio of markdown blockquotes, elastic#12491

* Fix fontsize of blockquotes in markdown, elastic#12904

* Add vis type description for screen reader, fix elastic#12887

The way tooltips are currently implemented we unfortunately cannot use
the tooltip for the aria-describedby. This is another issue to solve.

* Make main nav a11y when collapsed

* Camel case the vistype id used in HTML
chrisronline pushed a commit to chrisronline/kibana that referenced this issue Dec 1, 2017
@timroes @chrisronline
Improve accessibility of visualizations (elastic#13507)
da8cc5b 
* Fix markdown vis settings labels

* Fix contrast ratio of markdown blockquotes, elastic#12491

* Fix fontsize of blockquotes in markdown, elastic#12904

* Add vis type description for screen reader, fix elastic#12887

The way tooltips are currently implemented we unfortunately cannot use
the tooltip for the aria-describedby. This is another issue to solve.

* Make main nav a11y when collapsed

* Camel case the vistype id used in HTML
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timroes timroes

Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:Accessibility Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve accessibility of visualizations timroes/kibana
3 participants
@timroes @tbragin @cjcenizal