Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accessibility] Visual Builder "Auto Apply" field needs proper labeling #12900

Closed
aphelionz opened this issue Jul 16, 2017 · 1 comment · Fixed by #13726
Closed

[Accessibility] Visual Builder "Auto Apply" field needs proper labeling #12900

aphelionz opened this issue Jul 16, 2017 · 1 comment · Fixed by #13726
Assignees
@timroes
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:Accessibility upstream

Comments

@aphelionz
Copy link
Contributor

The screen reader simply reads "checkbox checked" here, it should be more descriptive.

image
@cjcenizal cjcenizal mentioned this issue Jul 16, 2017
Closed
20 tasks
@aphelionz aphelionz added Project:Accessibility Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Jul 16, 2017
@tbragin tbragin added the bug Fixes for quality problems that affect the customer experience label Jul 28, 2017
@alexfrancoeur alexfrancoeur added the Feature:TSVB TSVB (Time Series Visual Builder) label Aug 8, 2017
@thomasneirynck
Copy link
Contributor

upstream issue with react-toggle component

@timroes timroes self-assigned this Aug 23, 2017
timroes pushed a commit to timroes/kibana that referenced this issue Aug 25, 2017
Label TSVB auto apply button, fix elastic#12900
2f5bdfa
@timroes timroes mentioned this issue Aug 28, 2017
Merged
timroes added a commit that referenced this issue Aug 29, 2017
@timroes
Improve accessibility of visualization view (#13726)
4ddad1a 
* Use correct aria-label react attribute

* Label TSVB auto apply button, fix #12900

* Create possibility to conditionally disable input-focus directive

* Disable auto focus when creating a new viz, fix #12888

* Fix styling of label in TSVB

* Disable auto focus in visualizations, fix #11856

* Fix disable of auto focus

* Disable auto focus of index selection in vis wizard
timroes added a commit that referenced this issue Aug 29, 2017
@timroes
Improve accessibility of visualization view (#13726)
9d72dd0 
* Use correct aria-label react attribute

* Label TSVB auto apply button, fix #12900

* Create possibility to conditionally disable input-focus directive

* Disable auto focus when creating a new viz, fix #12888

* Fix styling of label in TSVB

* Disable auto focus in visualizations, fix #11856

* Fix disable of auto focus

* Disable auto focus of index selection in vis wizard
timroes added a commit that referenced this issue Aug 29, 2017
@timroes
Improve accessibility of visualization view (#13726)
c4c3ab1 
* Use correct aria-label react attribute

* Label TSVB auto apply button, fix #12900

* Create possibility to conditionally disable input-focus directive

* Disable auto focus when creating a new viz, fix #12888

* Fix styling of label in TSVB

* Disable auto focus in visualizations, fix #11856

* Fix disable of auto focus

* Disable auto focus of index selection in vis wizard
chrisronline pushed a commit to chrisronline/kibana that referenced this issue Nov 20, 2017
@timroes @chrisronline
Improve accessibility of visualization view (elastic#13726)
0b9b654 
* Use correct aria-label react attribute

* Label TSVB auto apply button, fix elastic#12900

* Create possibility to conditionally disable input-focus directive

* Disable auto focus when creating a new viz, fix elastic#12888

* Fix styling of label in TSVB

* Disable auto focus in visualizations, fix elastic#11856

* Fix disable of auto focus

* Disable auto focus of index selection in vis wizard
chrisronline pushed a commit to chrisronline/kibana that referenced this issue Dec 1, 2017
@timroes @chrisronline
Improve accessibility of visualization view (elastic#13726)
1961d89 
* Use correct aria-label react attribute

* Label TSVB auto apply button, fix elastic#12900

* Create possibility to conditionally disable input-focus directive

* Disable auto focus when creating a new viz, fix elastic#12888

* Fix styling of label in TSVB

* Disable auto focus in visualizations, fix elastic#11856

* Fix disable of auto focus

* Disable auto focus of index selection in vis wizard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timroes timroes

Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:Accessibility upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve accessibility of visualization view timroes/kibana
5 participants
@aphelionz @timroes @tbragin @thomasneirynck @alexfrancoeur