Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Deprecate agent total status in agent_status API response #135980

Closed
Tracked by #123150
juliaElastic opened this issue Jul 8, 2022 · 2 comments · Fixed by #151564
Closed
Tracked by #123150

[Fleet] Deprecate agent total status in agent_status API response #135980

juliaElastic opened this issue Jul 8, 2022 · 2 comments · Fixed by #151564
Assignees
@juliaElastic
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@juliaElastic
Copy link
Contributor

juliaElastic commented Jul 8, 2022 •
edited
Loading

Currently /agent_status Fleet API returns a total status in response, which includes all active agents. This is misleading because inactive agents are not included in total.
Deprecate total field and instead introduce statuses:

  • all: all active and inactive
  • active: all active

Originally posted by @joshdover in #135816 (comment)
@juliaElastic juliaElastic added the Team:Fleet Team label for Observability Data Collection Fleet team label Jul 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@juliaElastic juliaElastic self-assigned this Jul 8, 2022
@juliaElastic juliaElastic mentioned this issue Jul 8, 2022
Merged
1 task
@jen-huang jen-huang mentioned this issue Jul 21, 2022
Closed
21 tasks
@nimarezainia
Copy link
Contributor

Great idea. No definition required as it's pretty self explanatory.

@juliaElastic juliaElastic mentioned this issue Feb 17, 2023
Merged
1 task
juliaElastic added a commit that referenced this issue Feb 22, 2023
@juliaElastic
[Fleet] agent_status total deprecated, added all and active (#151564)
9ddb989 
## Summary

Fixes #135980

Marked `total` deprecated in `/agent_status` API response, instead added
`all` (all agents) and `active` (all - inactive - unenrolled).

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliaElastic juliaElastic

Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] agent_status total deprecated, added all and active juliaElastic/kibana
3 participants
@nimarezainia @elasticmachine @juliaElastic