Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Timepicker] Align the timepicker:refreshIntervalDefaults setting with the documentation #140249

Closed
dokmic opened this issue Sep 8, 2022 · 4 comments · Fixed by #161669
Closed
Assignees
Labels
documentation Feature:Search Querying infrastructure in Kibana Feature:Timepicker Timepicker impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)

Comments

@dokmic
Copy link
Contributor

dokmic commented Sep 8, 2022

After merging #66040, we have a schema definition for the timepicker:refreshIntervalDefaults setting, which is missing the display property.
This property is still present in the documentation example, but it doesn't seem to be used anywhere in the code.

We should either update the documentation or add it to the schema definition and reuse that in the code.

@dokmic dokmic added bug Fixes for quality problems that affect the customer experience Feature:Timepicker Timepicker Team:AppServicesSv labels Sep 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@Dosant
Copy link
Contributor

Dosant commented Sep 8, 2022

@dokmic, I am not sure what display was for. Also, if I am ready this right, display was already not supported in #66040. If you'd set it, you'd not get any effect.
Maybe we should just update the documentation

@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Sep 12, 2022
@petrklapka petrklapka added Feature:Search Querying infrastructure in Kibana Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) and removed Team:AppServicesSv labels Nov 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal
Copy link
Member

kertal commented Jul 3, 2023

Yes, we should update documentation for this. Removing the bug label

@kertal kertal added documentation and removed bug Fixes for quality problems that affect the customer experience labels Jul 3, 2023
amyjtechwriter added a commit that referenced this issue Jul 19, 2023
## Summary

Removing 'display' property as it's unused in
`timepicker:refreshIntervalDefaults`. Small docs change.

Previous:
<img width="819" alt="Screenshot 2023-07-11 at 15 59 03"
src="https://github.com/elastic/kibana/assets/61687663/4c89cbd9-3320-41cc-b28e-94060fab5a0b">


Updated:
<img width="794" alt="Screenshot 2023-07-11 at 15 59 17"
src="https://github.com/elastic/kibana/assets/61687663/e566d456-6eed-4193-bc11-8d6068a6b768">

Closes: #140249
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jul 19, 2023
## Summary

Removing 'display' property as it's unused in
`timepicker:refreshIntervalDefaults`. Small docs change.

Previous:
<img width="819" alt="Screenshot 2023-07-11 at 15 59 03"
src="https://github.com/elastic/kibana/assets/61687663/4c89cbd9-3320-41cc-b28e-94060fab5a0b">

Updated:
<img width="794" alt="Screenshot 2023-07-11 at 15 59 17"
src="https://github.com/elastic/kibana/assets/61687663/e566d456-6eed-4193-bc11-8d6068a6b768">

Closes: elastic#140249
(cherry picked from commit 798b0ef)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jul 19, 2023
## Summary

Removing 'display' property as it's unused in
`timepicker:refreshIntervalDefaults`. Small docs change.

Previous:
<img width="819" alt="Screenshot 2023-07-11 at 15 59 03"
src="https://github.com/elastic/kibana/assets/61687663/4c89cbd9-3320-41cc-b28e-94060fab5a0b">

Updated:
<img width="794" alt="Screenshot 2023-07-11 at 15 59 17"
src="https://github.com/elastic/kibana/assets/61687663/e566d456-6eed-4193-bc11-8d6068a6b768">

Closes: elastic#140249
(cherry picked from commit 798b0ef)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jul 19, 2023
## Summary

Removing 'display' property as it's unused in
`timepicker:refreshIntervalDefaults`. Small docs change.

Previous:
<img width="819" alt="Screenshot 2023-07-11 at 15 59 03"
src="https://github.com/elastic/kibana/assets/61687663/4c89cbd9-3320-41cc-b28e-94060fab5a0b">

Updated:
<img width="794" alt="Screenshot 2023-07-11 at 15 59 17"
src="https://github.com/elastic/kibana/assets/61687663/e566d456-6eed-4193-bc11-8d6068a6b768">

Closes: elastic#140249
(cherry picked from commit 798b0ef)
kibanamachine added a commit that referenced this issue Jul 19, 2023
…162225)

# Backport

This will backport the following commits from `main` to `7.17`:
- [[Docs] Removing 'display' property as it's unused
(#161669)](#161669)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"amyjtechwriter","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-19T10:00:57Z","message":"[Docs]
Removing 'display' property as it's unused (#161669)\n\n##
Summary\r\n\r\nRemoving 'display' property as it's unused
in\r\n`timepicker:refreshIntervalDefaults`. Small docs
change.\r\n\r\nPrevious:\r\n<img width=\"819\" alt=\"Screenshot
2023-07-11 at 15 59
03\"\r\nsrc=\"https://github.com/elastic/kibana/assets/61687663/4c89cbd9-3320-41cc-b28e-94060fab5a0b\">\r\n\r\n\r\nUpdated:\r\n<img
width=\"794\" alt=\"Screenshot 2023-07-11 at 15 59
17\"\r\nsrc=\"https://github.com/elastic/kibana/assets/61687663/e566d456-6eed-4193-bc11-8d6068a6b768\">\r\n\r\nCloses:
#140249","sha":"798b0ef49b4a6ee5fb7bb4816979d10f9d0ad02c","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","docs","v7.17.0","v8.8.0","v8.9.0","v8.10.0"],"number":161669,"url":"https://github.com/elastic/kibana/pull/161669","mergeCommit":{"message":"[Docs]
Removing 'display' property as it's unused (#161669)\n\n##
Summary\r\n\r\nRemoving 'display' property as it's unused
in\r\n`timepicker:refreshIntervalDefaults`. Small docs
change.\r\n\r\nPrevious:\r\n<img width=\"819\" alt=\"Screenshot
2023-07-11 at 15 59
03\"\r\nsrc=\"https://github.com/elastic/kibana/assets/61687663/4c89cbd9-3320-41cc-b28e-94060fab5a0b\">\r\n\r\n\r\nUpdated:\r\n<img
width=\"794\" alt=\"Screenshot 2023-07-11 at 15 59
17\"\r\nsrc=\"https://github.com/elastic/kibana/assets/61687663/e566d456-6eed-4193-bc11-8d6068a6b768\">\r\n\r\nCloses:
#140249","sha":"798b0ef49b4a6ee5fb7bb4816979d10f9d0ad02c"}},"sourceBranch":"main","suggestedTargetBranches":["7.17","8.8","8.9"],"targetPullRequestStates":[{"branch":"7.17","label":"v7.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161669","number":161669,"mergeCommit":{"message":"[Docs]
Removing 'display' property as it's unused (#161669)\n\n##
Summary\r\n\r\nRemoving 'display' property as it's unused
in\r\n`timepicker:refreshIntervalDefaults`. Small docs
change.\r\n\r\nPrevious:\r\n<img width=\"819\" alt=\"Screenshot
2023-07-11 at 15 59
03\"\r\nsrc=\"https://github.com/elastic/kibana/assets/61687663/4c89cbd9-3320-41cc-b28e-94060fab5a0b\">\r\n\r\n\r\nUpdated:\r\n<img
width=\"794\" alt=\"Screenshot 2023-07-11 at 15 59
17\"\r\nsrc=\"https://github.com/elastic/kibana/assets/61687663/e566d456-6eed-4193-bc11-8d6068a6b768\">\r\n\r\nCloses:
#140249","sha":"798b0ef49b4a6ee5fb7bb4816979d10f9d0ad02c"}}]}]
BACKPORT-->

Co-authored-by: amyjtechwriter <[email protected]>
kibanamachine added a commit that referenced this issue Jul 19, 2023
…62227)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[Docs] Removing 'display' property as it's unused
(#161669)](#161669)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"amyjtechwriter","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-19T10:00:57Z","message":"[Docs]
Removing 'display' property as it's unused (#161669)\n\n##
Summary\r\n\r\nRemoving 'display' property as it's unused
in\r\n`timepicker:refreshIntervalDefaults`. Small docs
change.\r\n\r\nPrevious:\r\n<img width=\"819\" alt=\"Screenshot
2023-07-11 at 15 59
03\"\r\nsrc=\"https://github.com/elastic/kibana/assets/61687663/4c89cbd9-3320-41cc-b28e-94060fab5a0b\">\r\n\r\n\r\nUpdated:\r\n<img
width=\"794\" alt=\"Screenshot 2023-07-11 at 15 59
17\"\r\nsrc=\"https://github.com/elastic/kibana/assets/61687663/e566d456-6eed-4193-bc11-8d6068a6b768\">\r\n\r\nCloses:
#140249","sha":"798b0ef49b4a6ee5fb7bb4816979d10f9d0ad02c","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","docs","v7.17.0","v8.8.0","v8.9.0","v8.10.0"],"number":161669,"url":"https://github.com/elastic/kibana/pull/161669","mergeCommit":{"message":"[Docs]
Removing 'display' property as it's unused (#161669)\n\n##
Summary\r\n\r\nRemoving 'display' property as it's unused
in\r\n`timepicker:refreshIntervalDefaults`. Small docs
change.\r\n\r\nPrevious:\r\n<img width=\"819\" alt=\"Screenshot
2023-07-11 at 15 59
03\"\r\nsrc=\"https://github.com/elastic/kibana/assets/61687663/4c89cbd9-3320-41cc-b28e-94060fab5a0b\">\r\n\r\n\r\nUpdated:\r\n<img
width=\"794\" alt=\"Screenshot 2023-07-11 at 15 59
17\"\r\nsrc=\"https://github.com/elastic/kibana/assets/61687663/e566d456-6eed-4193-bc11-8d6068a6b768\">\r\n\r\nCloses:
#140249","sha":"798b0ef49b4a6ee5fb7bb4816979d10f9d0ad02c"}},"sourceBranch":"main","suggestedTargetBranches":["7.17","8.8","8.9"],"targetPullRequestStates":[{"branch":"7.17","label":"v7.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161669","number":161669,"mergeCommit":{"message":"[Docs]
Removing 'display' property as it's unused (#161669)\n\n##
Summary\r\n\r\nRemoving 'display' property as it's unused
in\r\n`timepicker:refreshIntervalDefaults`. Small docs
change.\r\n\r\nPrevious:\r\n<img width=\"819\" alt=\"Screenshot
2023-07-11 at 15 59
03\"\r\nsrc=\"https://github.com/elastic/kibana/assets/61687663/4c89cbd9-3320-41cc-b28e-94060fab5a0b\">\r\n\r\n\r\nUpdated:\r\n<img
width=\"794\" alt=\"Screenshot 2023-07-11 at 15 59
17\"\r\nsrc=\"https://github.com/elastic/kibana/assets/61687663/e566d456-6eed-4193-bc11-8d6068a6b768\">\r\n\r\nCloses:
#140249","sha":"798b0ef49b4a6ee5fb7bb4816979d10f9d0ad02c"}}]}]
BACKPORT-->

Co-authored-by: amyjtechwriter <[email protected]>
kibanamachine added a commit that referenced this issue Jul 19, 2023
…62226)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Docs] Removing 'display' property as it's unused
(#161669)](#161669)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"amyjtechwriter","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-19T10:00:57Z","message":"[Docs]
Removing 'display' property as it's unused (#161669)\n\n##
Summary\r\n\r\nRemoving 'display' property as it's unused
in\r\n`timepicker:refreshIntervalDefaults`. Small docs
change.\r\n\r\nPrevious:\r\n<img width=\"819\" alt=\"Screenshot
2023-07-11 at 15 59
03\"\r\nsrc=\"https://github.com/elastic/kibana/assets/61687663/4c89cbd9-3320-41cc-b28e-94060fab5a0b\">\r\n\r\n\r\nUpdated:\r\n<img
width=\"794\" alt=\"Screenshot 2023-07-11 at 15 59
17\"\r\nsrc=\"https://github.com/elastic/kibana/assets/61687663/e566d456-6eed-4193-bc11-8d6068a6b768\">\r\n\r\nCloses:
#140249","sha":"798b0ef49b4a6ee5fb7bb4816979d10f9d0ad02c","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","docs","v7.17.0","v8.8.0","v8.9.0","v8.10.0"],"number":161669,"url":"https://github.com/elastic/kibana/pull/161669","mergeCommit":{"message":"[Docs]
Removing 'display' property as it's unused (#161669)\n\n##
Summary\r\n\r\nRemoving 'display' property as it's unused
in\r\n`timepicker:refreshIntervalDefaults`. Small docs
change.\r\n\r\nPrevious:\r\n<img width=\"819\" alt=\"Screenshot
2023-07-11 at 15 59
03\"\r\nsrc=\"https://github.com/elastic/kibana/assets/61687663/4c89cbd9-3320-41cc-b28e-94060fab5a0b\">\r\n\r\n\r\nUpdated:\r\n<img
width=\"794\" alt=\"Screenshot 2023-07-11 at 15 59
17\"\r\nsrc=\"https://github.com/elastic/kibana/assets/61687663/e566d456-6eed-4193-bc11-8d6068a6b768\">\r\n\r\nCloses:
#140249","sha":"798b0ef49b4a6ee5fb7bb4816979d10f9d0ad02c"}},"sourceBranch":"main","suggestedTargetBranches":["7.17","8.8","8.9"],"targetPullRequestStates":[{"branch":"7.17","label":"v7.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161669","number":161669,"mergeCommit":{"message":"[Docs]
Removing 'display' property as it's unused (#161669)\n\n##
Summary\r\n\r\nRemoving 'display' property as it's unused
in\r\n`timepicker:refreshIntervalDefaults`. Small docs
change.\r\n\r\nPrevious:\r\n<img width=\"819\" alt=\"Screenshot
2023-07-11 at 15 59
03\"\r\nsrc=\"https://github.com/elastic/kibana/assets/61687663/4c89cbd9-3320-41cc-b28e-94060fab5a0b\">\r\n\r\n\r\nUpdated:\r\n<img
width=\"794\" alt=\"Screenshot 2023-07-11 at 15 59
17\"\r\nsrc=\"https://github.com/elastic/kibana/assets/61687663/e566d456-6eed-4193-bc11-8d6068a6b768\">\r\n\r\nCloses:
#140249","sha":"798b0ef49b4a6ee5fb7bb4816979d10f9d0ad02c"}}]}]
BACKPORT-->

Co-authored-by: amyjtechwriter <[email protected]>
ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
## Summary

Removing 'display' property as it's unused in
`timepicker:refreshIntervalDefaults`. Small docs change.

Previous:
<img width="819" alt="Screenshot 2023-07-11 at 15 59 03"
src="https://github.com/elastic/kibana/assets/61687663/4c89cbd9-3320-41cc-b28e-94060fab5a0b">


Updated:
<img width="794" alt="Screenshot 2023-07-11 at 15 59 17"
src="https://github.com/elastic/kibana/assets/61687663/e566d456-6eed-4193-bc11-8d6068a6b768">

Closes: elastic#140249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Feature:Search Querying infrastructure in Kibana Feature:Timepicker Timepicker impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants