[Discover] Extract DiscoverGridFlyout from DiscoverGrid component

[kertal]

For our future work to create a unified_data_table and beyond that also to provide a unified experience when expanding a document, it is necessary to decouple DiscoverGridFlyout

kibana/src/plugins/discover/public/components/discover_grid/discover_grid.tsx

Lines 618 to 629 in 5a0e61b

	<DiscoverGridFlyout
	dataView={dataView}
	hit={expandedDoc}
	hits={displayedRows}
	// if default columns are used, dont make them part of the URL - the context state handling will take care to restore them
	columns={defaultColumns ? [] : displayedColumns}
	onFilter={onFilter}
	onRemoveColumn={onRemoveColumn}
	onAddColumn={onAddColumn}
	onClose={() => setExpandedDoc(undefined)}
	setExpandedDoc={setExpandedDoc}
	/>

from DiscoverGrid:

kibana/src/plugins/discover/public/components/discover_grid/discover_grid.tsx

Lines 187 to 195 in 5a0e61b

	export const DiscoverGrid = ({
	ariaLabelledBy,
	columns,
	dataView,
	isLoading,
	expandedDoc,
	onAddColumn,
	onFilter,
	onRemoveColumn,

DiscoverGrid should get a new param like onExpandDoc, which should trigger displaying the expanded document.

When extracting DiscoverGridFlyout it is also necessary to extract stateful functionality like the document selection. This allows users to select documents and in the flyout, they should be able to use pagination to navigate to the previous/next document

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[michaelolo24]

@mattkime or @kertal, will the plan to be to turn the entire flyout into a consumable package, or turn the components (i.e., table, json, pagination) into consumable components? We have a similar flyout in security currently, so it would be great to be able to utilize this functionality in security instead of maintaining our own which is behind the current Discover one in the table and json functionality. One thing we currently have in addition to those is the concept of the alert detail view that we'd want to maintain. Being able to combine them on our end would be awesome 😄.

With that said, the alert detail view is potentially extensible to any regular event as well, so maybe another option is being able to enhance your component with that information as well. Anyways, just wanted to start a discussion about it!

Screen.Recording.2022-11-29.at.10.54.06.AM.mov

[kertal]

@michaelolo24 yes, this is exactly what we intend to do, it will be the unified doc viewer, also providing parts / components like the JSON tab of it will be possible. Resolving this issue is a requirement for further work in this area. Thx a lot for giving info about a new potential consumer of this work. FYI @lukasolson @ninoslavmiskovic

[michaelolo24]

Fantastic, thanks for the update! Let me know if there's any way I can help @kertal !