Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Add test coverage for the JSON diff tab of prebuilt rule flyout #166163

Closed
Tracked by #174167
nikitaindik opened this issue Sep 11, 2023 · 2 comments · Fixed by #176770
Closed
Tracked by #174167

[Security Solution] Add test coverage for the JSON diff tab of prebuilt rule flyout #166163

nikitaindik opened this issue Sep 11, 2023 · 2 comments · Fixed by #176770
Assignees
@nikitaindik
Labels
8.13 candidate Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test-coverage issues & PRs for improving code test coverage

Comments

@nikitaindik
Copy link
Contributor

nikitaindik commented Sep 11, 2023 •
edited by banderror
Loading

Epic: https://github.com/elastic/security-team/issues/1974 (internal)

Summary

Write tests based on the approved test plan (#166162)
@nikitaindik nikitaindik added the Team:Detection Rule Management Security Detection Rule Management Team label Sep 11, 2023
@nikitaindik nikitaindik self-assigned this Sep 11, 2023
@banderror banderror changed the title Add test coverage for the Diff tab of prebuilt rule flyout [Security Solution] Add test coverage for the Diff tab of prebuilt rule flyout Sep 12, 2023
@banderror banderror added test-coverage issues & PRs for improving code test coverage Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules 8.11 candidate labels Sep 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@banderror banderror assigned dplumlee and unassigned nikitaindik Oct 13, 2023
@banderror banderror changed the title [Security Solution] Add test coverage for the Diff tab of prebuilt rule flyout [Security Solution] Add test coverage for the JSON diff tab of prebuilt rule flyout Jan 3, 2024
@banderror banderror mentioned this issue Jan 3, 2024
Closed
@nikitaindik nikitaindik mentioned this issue Feb 14, 2024
Merged
nikitaindik added a commit that referenced this issue Feb 19, 2024
@nikitaindik
[Security Solution] JSON diffs test coverage (#176770)
cd374d2 
**Resolves: #166163

Flaky test runner runs:
[1](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5189),
[2](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5190),
[3](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5191),
[4](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5192)

## Summary
This PR adds tests in accordance with the [test
plan](#175958) that was merged
earlier.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Feb 19, 2024
@nikitaindik
[Security Solution] JSON diffs test coverage (elastic#176770)
385ea9d 
**Resolves: elastic#166163

Flaky test runner runs:
[1](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5189),
[2](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5190),
[3](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5191),
[4](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5192)

## Summary
This PR adds tests in accordance with the [test
plan](elastic#175958) that was merged
earlier.

(cherry picked from commit cd374d2)
kibanamachine referenced this issue Feb 19, 2024
@kibanamachine @nikitaindik
[8.13] [Security Solution] JSON diffs test coverage (#176770) (#177209)
83623a7 
# Backport

This will backport the following commits from `main` to `8.13`:
- [[Security Solution] JSON diffs test coverage
(#176770)](#176770)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nikita
Indik","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-02-19T15:12:51Z","message":"[Security
Solution] JSON diffs test coverage (#176770)\n\n**Resolves:
https://github.com/elastic/kibana/issues/166163**\r\n\r\nFlaky test
runner
runs:\r\n[1](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5189),\r\n[2](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5190),\r\n[3](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5191),\r\n[4](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5192)\r\n\r\n##
Summary\r\nThis PR adds tests in accordance with the
[test\r\nplan](#175958) that was
merged\r\nearlier.","sha":"cd374d23368de182a96df0948192a9bca7bdc4aa","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","test-coverage","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection Rule
Management","Feature:Prebuilt Detection
Rules","v8.13.0","v8.14.0"],"title":"[Security Solution] JSON diffs test
coverage","number":176770,"url":"https://github.com/elastic/kibana/pull/176770","mergeCommit":{"message":"[Security
Solution] JSON diffs test coverage (#176770)\n\n**Resolves:
https://github.com/elastic/kibana/issues/166163**\r\n\r\nFlaky test
runner
runs:\r\n[1](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5189),\r\n[2](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5190),\r\n[3](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5191),\r\n[4](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5192)\r\n\r\n##
Summary\r\nThis PR adds tests in accordance with the
[test\r\nplan](#175958) that was
merged\r\nearlier.","sha":"cd374d23368de182a96df0948192a9bca7bdc4aa"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176770","number":176770,"mergeCommit":{"message":"[Security
Solution] JSON diffs test coverage (#176770)\n\n**Resolves:
https://github.com/elastic/kibana/issues/166163**\r\n\r\nFlaky test
runner
runs:\r\n[1](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5189),\r\n[2](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5190),\r\n[3](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5191),\r\n[4](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5192)\r\n\r\n##
Summary\r\nThis PR adds tests in accordance with the
[test\r\nplan](#175958) that was
merged\r\nearlier.","sha":"cd374d23368de182a96df0948192a9bca7bdc4aa"}}]}]
BACKPORT-->

Co-authored-by: Nikita Indik <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
@nikitaindik @fkanout
[Security Solution] JSON diffs test coverage (elastic#176770)
6af04b8 
**Resolves: elastic#166163

Flaky test runner runs:
[1](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5189),
[2](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5190),
[3](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5191),
[4](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5192)

## Summary
This PR adds tests in accordance with the [test
plan](elastic#175958) that was merged
earlier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikitaindik nikitaindik

Labels
8.13 candidate Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test-coverage issues & PRs for improving code test coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Security Solution] JSON diffs test coverage nikitaindik/kibana
4 participants
@banderror @elasticmachine @nikitaindik @dplumlee