Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Increase Test Coverage 8.12.0 #168458

Closed
8 tasks done
peteharverson opened this issue Oct 10, 2023 · 2 comments
Closed
8 tasks done

[ML] Increase Test Coverage 8.12.0 #168458

peteharverson opened this issue Oct 10, 2023 · 2 comments
Assignees
@walterra @darnautov @alvarezmelissa87 @peteharverson @jgowdyelastic @qn895
Labels
Meta :ml v8.12.0

Comments

@peteharverson
Copy link
Contributor

peteharverson commented Oct 10, 2023 •
edited
Loading

Follow up to #164562

Meta issue to summarize improvements to test coverage for 8.12.0.

Jest unit tests

API integration tests

Serverless tests

Functional tests
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson mentioned this issue Dec 8, 2023
Merged
jgowdyelastic added a commit that referenced this issue Dec 11, 2023
@jgowdyelastic
[ML] Category job results API test (#172840)
efe8362 
Creates a categorization job and tests:
The response from `/internal/ml/jobs/top_categories` matches the
expected top categories.
The response from
`/internal/ml/anomaly_detectors/${jobId}/results/categories/${categoryId}`
matches the correct selected category.

Part of #168458
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 11, 2023
@jgowdyelastic
[ML] Category job results API test (elastic#172840)
997f182 
Creates a categorization job and tests:
The response from `/internal/ml/jobs/top_categories` matches the
expected top categories.
The response from
`/internal/ml/anomaly_detectors/${jobId}/results/categories/${categoryId}`
matches the correct selected category.

Part of elastic#168458

(cherry picked from commit efe8362)
kibanamachine referenced this issue Dec 11, 2023
@kibanamachine @jgowdyelastic
[8.12] [ML] Category job results API test (#172840) (#173023)
92e4828 
# Backport

This will backport the following commits from `main` to `8.12`:
- [[ML] Category job results API test
(#172840)](#172840)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-11T09:04:50Z","message":"[ML]
Category job results API test (#172840)\n\nCreates a categorization job
and tests:\r\nThe response from `/internal/ml/jobs/top_categories`
matches the\r\nexpected top categories.\r\nThe response
from\r\n`/internal/ml/anomaly_detectors/${jobId}/results/categories/${categoryId}`\r\nmatches
the correct selected category.\r\n\r\nPart of
https://github.com/elastic/kibana/issues/168458","sha":"efe8362d23a6f82005195df41c17271c2f48e0db","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["non-issue",":ml","Feature:Anomaly
Detection","release_note:skip","v8.12.0","v8.13.0"],"number":172840,"url":"https://github.com/elastic/kibana/pull/172840","mergeCommit":{"message":"[ML]
Category job results API test (#172840)\n\nCreates a categorization job
and tests:\r\nThe response from `/internal/ml/jobs/top_categories`
matches the\r\nexpected top categories.\r\nThe response
from\r\n`/internal/ml/anomaly_detectors/${jobId}/results/categories/${categoryId}`\r\nmatches
the correct selected category.\r\n\r\nPart of
https://github.com/elastic/kibana/issues/168458","sha":"efe8362d23a6f82005195df41c17271c2f48e0db"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172840","number":172840,"mergeCommit":{"message":"[ML]
Category job results API test (#172840)\n\nCreates a categorization job
and tests:\r\nThe response from `/internal/ml/jobs/top_categories`
matches the\r\nexpected top categories.\r\nThe response
from\r\n`/internal/ml/anomaly_detectors/${jobId}/results/categories/${categoryId}`\r\nmatches
the correct selected category.\r\n\r\nPart of
https://github.com/elastic/kibana/issues/168458","sha":"efe8362d23a6f82005195df41c17271c2f48e0db"}}]}]
BACKPORT-->

Co-authored-by: James Gowdy <[email protected]>
@peteharverson peteharverson mentioned this issue Dec 13, 2023
Closed
11 tasks
@peteharverson
Copy link
Contributor Author

Closing issue as all items planned for 8.12.0 have been completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@walterra walterra

@darnautov darnautov

@alvarezmelissa87 alvarezmelissa87

@peteharverson peteharverson

@jgowdyelastic jgowdyelastic

@qn895 qn895

Labels
Meta :ml v8.12.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@walterra @darnautov @alvarezmelissa87 @peteharverson @elasticmachine @jgowdyelastic @qn895