Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Markdown text settings are not honoured #179940

Closed
sakurai-youhei opened this issue Apr 3, 2024 · 1 comment · Fixed by #179948
Closed

[Canvas] Markdown text settings are not honoured #179940

sakurai-youhei opened this issue Apr 3, 2024 · 1 comment · Fixed by #179948
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@sakurai-youhei
Copy link
Member

sakurai-youhei commented Apr 3, 2024 •
edited
Loading

Kibana version: 8.13.0+

Elasticsearch version: 8.13.0+

Server OS version: 8.13.0+

Browser version: Chrome Version 123.0.6312.86 (Official Build) (64-bit)

Browser OS version: Windows

Original install method: Elasticsearch Service

Describe the bug:

Text settings won't be propagated to the style attribute.

Steps to reproduce:

  1. Create a new workpad and add a text.
  2. Set the following expression using editor: 
    kibana
| markdown "font test" 
  font={font color="red"}
| render
  3. Click Run.
  4. The font color doesn't change to red.

Expected behavior: The font color should change to red.

Screenshots:

8.13.1
image

8.12.2
image

Any additional context:

I will open a PR to fix this issue.
@sakurai-youhei sakurai-youhei added bug Fixes for quality problems that affect the customer experience Feature:Canvas labels Apr 3, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 3, 2024
@kibanamachine kibanamachine added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:needs-research This issue requires some research before it can be worked on or estimated impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Apr 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 3, 2024
@sakurai-youhei sakurai-youhei mentioned this issue Apr 3, 2024
Merged
2 tasks
@nreese nreese mentioned this issue Apr 3, 2024
Closed
@Dosant Dosant mentioned this issue Apr 4, 2024
Merged
Dosant added a commit that referenced this issue Apr 5, 2024
@Dosant
[Docs] Add markdown related issues to the 8.13 known issues (#180041)
0feeb3a 
## Summary

#179611
#179498
#179940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix text settings to be honored in Canvas markdown elements sakurai-youhei/kibana
3 participants
@sakurai-youhei @elasticmachine @kibanamachine