Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Make rule_source field required in RuleResponse #180270

Closed
Tracked by #174168
jpdjere opened this issue Apr 8, 2024 · 3 comments · Fixed by #193636
Closed
Tracked by #174168

[Security Solution] Make rule_source field required in RuleResponse #180270

jpdjere opened this issue Apr 8, 2024 · 3 comments · Fixed by #193636
Assignees
@dplumlee
Labels
8.16 candidate Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0

Comments

@jpdjere
Copy link
Contributor

jpdjere commented Apr 8, 2024 •
edited by banderror
Loading

Epics: https://github.com/elastic/security-team/issues/1974 (internal), #174168
Depends on: #180140

Summary

Make the rule_source property required in RuleResponse.
@jpdjere jpdjere added triage_needed Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area labels Apr 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@jpdjere jpdjere mentioned this issue Apr 8, 2024
Open
@banderror banderror changed the title [Security Solution] Make the rule_source property required in RuleResponse [Security Solution] Make the rule_source property required in RuleResponse (DRAFT) Apr 17, 2024
@jpdjere jpdjere changed the title [Security Solution] Make the rule_source property required in RuleResponse (DRAFT) [Security Solution] Make the rule_source property required in RuleResponse (DRAFT) (BLOCKED) Jul 4, 2024
@banderror banderror mentioned this issue Jul 5, 2024
Open
@banderror banderror changed the title [Security Solution] Make the rule_source property required in RuleResponse (DRAFT) (BLOCKED) [Security Solution] Make rule_source required in RuleResponse Jul 5, 2024
@banderror banderror changed the title [Security Solution] Make rule_source required in RuleResponse [Security Solution] Make rule_source field required in RuleResponse Jul 5, 2024
@jpdjere jpdjere mentioned this issue Aug 28, 2024
Merged
4 tasks
@dplumlee dplumlee assigned dplumlee and unassigned jpdjere Sep 19, 2024
@dplumlee dplumlee mentioned this issue Sep 20, 2024
Merged
3 tasks
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 7, 2024
@dplumlee
[Security Solution] Makes rule_source a required field in `RuleResp…
dc9ba6d 
…onse` (elastic#193636)

**Resolves elastic#180270

## Summary

Sets `rule_source` to be a required field in the `RuleResponse` type

### Checklist

Delete any items that are not applicable to this PR.

- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 484f95e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dplumlee dplumlee

Labels
8.16 candidate Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Security Solution] Makes rule_source a required field in RuleResponse dplumlee/kibana
4 participants
@jpdjere @banderror @elasticmachine @dplumlee