-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Meta][FTR] Move services to packages #188541
Comments
Pinging @elastic/appex-qa (Team:QA) |
wayneseymour
added a commit
to wayneseymour/kibana
that referenced
this issue
Aug 27, 2024
wayneseymour
added a commit
to wayneseymour/kibana
that referenced
this issue
Aug 27, 2024
wayneseymour
added a commit
to wayneseymour/kibana
that referenced
this issue
Aug 30, 2024
wayneseymour
added a commit
that referenced
this issue
Sep 5, 2024
…tional-[ui-]services/* (#191805) ## Summary Moving common services to respective new homes. This PR is revived from a previously [merged](09a3658) and [reverted PR](#191765) as [detailed here](#189051 (comment)). - This was due to "extra" tests being applied to #191708 - These "extra" tests were applied as #191708 changes files within `x-pack/plugins/observability_solution/` as configured [here](https://github.com/elastic/kibana/blob/main/.buildkite/scripts/pipelines/pull_request/pipeline.ts#L129) ### Why these failures were not caught in the original [PR](#189051) The pipeline is generated at runtime, and the original [PR](#189051) had zero changes under `x-pack/plugins/observability_solution/` ## Changes on top of original PR - Add `ci:all-cypress-suites` label to run extra tests - Add `services` stanza to which contains the missing references by spreading the services from `@kbn/ftr-common-functional-services` && `@kbn/ftr-common-functional-ui-services` into the stanza, for the following: - `x-pack/plugins/observability_solution/synthetics/e2e/config.ts` - `x-pack/plugins/observability_solution/apm/ftr_e2e/ftr_config.ts` - `x-pack/plugins/observability_solution/observability_onboarding/e2e/ftr_config.ts` - `x-pack/plugins/observability_solution/profiling/e2e/ftr_config.ts` - `x-pack/plugins/observability_solution/synthetics/e2e/config.ts` - `x-pack/plugins/observability_solution/uptime/e2e/config.ts` Blocked by: #191961 Resolves: #188541 --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Currently we are locked when desiring to use a services beyond boundaries.
Similar to #174048 we are moving them to packages under
https://github.com/elastic/kibana/tree/main/packages/kbn-ftr-common-functional-services or https://github.com/elastic/kibana/tree/main/packages/kbn-ftr-common-functional-ui-services, respectively.
The first in the
test/common/services
list is bsearch:The text was updated successfully, but these errors were encountered: