-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra] Consider only docs from system and APM in the hosts view #188756
Labels
enhancement
New value added to drive a business result
Feature:ObsHosts
Hosts feature within Observability
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
Comments
crespocarlos
added
the
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
label
Jul 19, 2024
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
The new filter will affect the otel onboarding. I created a proposal to address it: https://github.com/elastic/opentelemetry-dev/issues/338 |
jennypavlova
added a commit
that referenced
this issue
Jul 25, 2024
Closes #188757 ## Summary This PR adds an endpoint to get the hosts (monitored by the system integration) count. Currently, it supports only hosts but it can be extended to other asset types (if/when needed). So the endpoint ( **POST /api/infra/{assetType}/count** ) supports only 'host' as `{assetType}`.⚠️ This PR adds only the endpoint - it is not used yet! To avoid having different host counts and results shown on the UI this PR is not updating the hook responsible for the request because currently the hosts shown in the table are not filtered by the system integration (showing the filtered result of this endpoint can lead to inconsistencies between the count and the results shown in the table) Once [#188756](#188756) and [#188752](#188752) are done we can use this endpoint. ## Testing It can't be tested in the UI so we can test it: <details> <summary>Using curl:</summary> ```bash curl --location -u elastic:changeme 'http://0.0.0.0:5601/ftw/api/infra/host/count' \ --header 'kbn-xsrf: xxxx' \ --header 'Content-Type: application/json' \ --data '{ "query": { "bool": { "must": [], "filter": [], "should": [], "must_not": [] } }, "from": "2024-07-23T11:34:11.640Z", "to": "2024-07-23T11:49:11.640Z", "sourceId": "default" }' ``` </details> In case of testing with oblt replace the `elastic:changeme` with your user and password
crespocarlos
changed the title
[Infra] Consider only docs from system integration in the hosts view
[Infra] Consider only docs from system and APM in the hosts view
Aug 7, 2024
The scope of the ticket was changed due to the impossibility of successfully filter out APM docs without compromising the current feature too much. |
This was referenced Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New value added to drive a business result
Feature:ObsHosts
Hosts feature within Observability
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
Summary
Infra has only one setting to define the index pattern. The index pattern can be as generic as
metric-*
which also includes APM indices and any other integration that sendshost.name
field.In the hosts view we need to consider only docs generated by the system module and APM.
For that we can apply a filter by
event.module: 'system'
ormetricset.module: 'system'
to the queries. To continue supporting filter byservice.name
(or any other APM fields), we'll build a service in APM data access to return host names,This is what the API needs to do:
Extra
Change the
metrics/infra
endpoint to accept thetype
as path parameter ->metrics/infra/{assetType}
Acceptance Criteria
system
module and APM are returned by the APIsystem
module and APM are considered in the hosts count.service.name
worksadservice
,packetbeat
,frontend
,cartservice
,recommendationservice
,frauddetectionservice
,accountingservice
,cartservice
,productcatalogservice
The text was updated successfully, but these errors were encountered: