Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Deprecation Issue for Team: kibana-visualizations, Found in file: dialog.scss #190906

Closed
Tracked by #190345
petrklapka opened this issue Aug 20, 2024 · 1 comment · Fixed by #193864
Closed
Tracked by #190345
Labels
Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@petrklapka
Copy link
Member

DEPRECATION: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in & {}.

The file below has one or more instances where CSS behavior will change unless
the declaration is moved above the nested rule. Line numbers for the declaration
along with the file and line numbers in which the nested rule appears are
shown below.

More info: https://sass-lang.com/d/mixed-decls

kibana/src/plugins/visualizations/public/wizard/dialog.scss

   ┌──> kibana/src/plugins/visualizations/public/wizard/dialog.scss
10 │     max-width: $modalWidth;
   │     ^^^^^^^^^^^^^^^^^^^^^^ declaration
   ╵
   ┌──> kibana/node_modules/@elastic/eui/src/global_styling/mixins/_responsive.scss
34 │ ┌           @media only screen and (min-width: $minSize) and (max-width: $maxSize) {
35 │ │             @content;
36 │ │           }
   │ └─── nested rule
   ╵

   ┌──> kibana/src/plugins/visualizations/public/wizard/dialog.scss
11 │     max-height: $modalHeight;
   │     ^^^^^^^^^^^^^^^^^^^^^^^^ declaration
   ╵
   ┌──> kibana/node_modules/@elastic/eui/src/global_styling/mixins/_responsive.scss
34 │ ┌           @media only screen and (min-width: $minSize) and (max-width: $maxSize) {
35 │ │             @content;
36 │ │           }
   │ └─── nested rule
   ╵

   ┌──> kibana/src/plugins/visualizations/public/wizard/dialog.scss
12 │     background: $euiColorEmptyShade;
   │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ declaration
   ╵
   ┌──> kibana/node_modules/@elastic/eui/src/global_styling/mixins/_responsive.scss
34 │ ┌           @media only screen and (min-width: $minSize) and (max-width: $maxSize) {
35 │ │             @content;
36 │ │           }
   │ └─── nested rule
   ╵

   ┌──> kibana/src/plugins/visualizations/public/wizard/dialog.scss
20 │     max-width: $modalWidth;
   │     ^^^^^^^^^^^^^^^^^^^^^^ declaration
   ╵
   ┌──> kibana/node_modules/@elastic/eui/src/global_styling/mixins/_responsive.scss
34 │ ┌           @media only screen and (min-width: $minSize) and (max-width: $maxSize) {
35 │ │             @content;
36 │ │           }
   │ └─── nested rule
   ╵

   ┌──> kibana/src/plugins/visualizations/public/wizard/dialog.scss
21 │     max-height: $modalHeight;
   │     ^^^^^^^^^^^^^^^^^^^^^^^^ declaration
   ╵
   ┌──> kibana/node_modules/@elastic/eui/src/global_styling/mixins/_responsive.scss
34 │ ┌           @media only screen and (min-width: $minSize) and (max-width: $maxSize) {
35 │ │             @content;
36 │ │           }
   │ └─── nested rule
   ╵
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 20, 2024
@petrklapka petrklapka added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Aug 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants