Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SASS mixed-declations deprecation warnings #190345

Closed
42 tasks done
jbudz opened this issue Aug 12, 2024 · 1 comment
Closed
42 tasks done

Fix SASS mixed-declations deprecation warnings #190345

jbudz opened this issue Aug 12, 2024 · 1 comment
Assignees
@jbudz @petrklapka
Labels
Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@jbudz
Copy link
Member

jbudz commented Aug 12, 2024 •
edited by petrklapka
Loading

A recent CSS SASS update caused 1.1MB of warning text in the dev console.

We will be muting the mixed-decls SASS warning due to the verbosity impacting DX. This issue is for tracking source code remediation of the deprecation warnings.

More info: https://sass-lang.com/d/mixed-decls

Tracking issues for codeowner teams have been created as follows:

Tasks
Beta Give feedback
  1. CSS Deprecation Issue for Team: appex-sharedux, Found in file: collapsible_nav.scss #190886
    Team:SharedUX bug
    tsullivan
  2. CSS Deprecation Issue for Team: appex-sharedux, Found in file: solution_nav.scss #190887
    Team:SharedUX
  3. CSS Deprecation Issue for Team: kibana-data-discovery, Found in file: discover_layout.scss #190888
    Team:DataDiscovery chore impact:medium loe:small
    jughosta
  4. CSS Deprecation Issue for Team: kibana-data-discovery, Found in file: draggable.scss #190889
    Team:DataDiscovery chore impact:medium loe:small
    jughosta
  5. CSS Deprecation Issue for Team: kibana-data-discovery, Found in file: field_list_grouped.scss #190890
    Team:DataDiscovery chore good first issue impact:medium loe:small
    jughosta
  6. CSS Deprecation Issue for Team: kibana-data-discovery, Found in file: render_custom_toolbar.scss #190891
    Team:DataDiscovery chore impact:medium loe:small
    jughosta
  7. CSS Deprecation Issue for Team: kibana-esql, Found in file: documentation.scss #190892
    Team:ESQL
    stratoula vadimkibana
  8. CSS Deprecation Issue for Team: kibana-management, Found in file: processors_tree.scss #190893
    Team:Kibana Management
    sabarasaba
  9. CSS Deprecation Issue for Team: kibana-presentation, Found in file: control_group.scss #190894
    Team:Presentation impact:low loe:small
    Heenawter
  10. CSS Deprecation Issue for Team: kibana-presentation, Found in file: debug.scss #190895
    Team:Presentation impact:low loe:small
    nreese
  11. CSS Deprecation Issue for Team: kibana-presentation, Found in file: editor_menu.scss #190896
    Team:Presentation impact:low loe:small
    nreese
  12. CSS Deprecation Issue for Team: kibana-presentation, Found in file: input_control_vis.scss #190897
    Team:Presentation impact:low loe:small
    nreese
  13. CSS Deprecation Issue for Team: kibana-security, Found in file: access_agreement_page.scss #190898
    Team:Security chore
    kc13greiner
  14. CSS Deprecation Issue for Team: kibana-security, Found in file: app.scss #190899
    Team:Security chore
    kc13greiner
  15. CSS Deprecation Issue for Team: kibana-security, Found in file: authentication_state_page.scss #190900
    Team:Security chore
    kc13greiner
  16. CSS Deprecation Issue for Team: kibana-security, Found in file: login_form.scss #190901
    Team:Security chore
    kc13greiner
  17. CSS Deprecation Issue for Team: kibana-security, Found in file: login_page.scss #190902
    Team:Security chore
    kc13greiner
  18. CSS Deprecation Issue for Team: kibana-security, Found in file: space_selector.scss #190903
    Team:Security chore
    kc13greiner
  19. CSS Deprecation Issue for Team: kibana-security, Found in file: spaces_menu.scss #190904
    Team:Security chore
    kc13greiner
  20. CSS Deprecation Issue for Team: kibana-visualizations, Found in file: _markdown.scss #190905
    Team:Visualizations
  21. CSS Deprecation Issue for Team: kibana-visualizations, Found in file: dialog.scss #190906
    Team:Visualizations
  22. CSS Deprecation Issue for Team: kibana-visualizations, Found in file: embeddable_info_badges.scss #190907
    Team:Visualizations
  23. CSS Deprecation Issue for Team: kibana-visualizations, Found in file: filter_item.scss #190908
    Team:Visualizations
  24. CSS Deprecation Issue for Team: kibana-visualizations, Found in file: flyout_container.scss #190909
    Team:Visualizations
  25. CSS Deprecation Issue for Team: kibana-visualizations, Found in file: frame_layout.scss #190910
    Team:Visualizations
  26. CSS Deprecation Issue for Team: kibana-visualizations, Found in file: group_selection.scss #190911
    Team:Visualizations
  27. CSS Deprecation Issue for Team: kibana-visualizations, Found in file: help_popover.scss #190912
    Team:Visualizations
  28. CSS Deprecation Issue for Team: kibana-visualizations, Found in file: helpers.scss #190913
    Team:Visualizations
  29. CSS Deprecation Issue for Team: kibana-visualizations, Found in file: index.scss #190914
    Team:Visualizations
  30. CSS Deprecation Issue for Team: kibana-visualizations, Found in file: layer_panel.scss #190915
    Team:Visualizations
  31. CSS Deprecation Issue for Team: kibana-visualizations, Found in file: message_list.scss #190916
    Team:Visualizations
  32. CSS Deprecation Issue for Team: kibana-visualizations, Found in file: metric.scss #190917
    Team:Visualizations
  33. CSS Deprecation Issue for Team: kibana-visualizations, Found in file: saved_query_management_list.scss #190918
    Team:Visualizations
  34. CSS Deprecation Issue for Team: kibana-visualizations, Found in file: setting_with_sibling_flyout.scss #190919
    Team:Visualizations
  35. CSS Deprecation Issue for Team: kibana-visualizations, Found in file: suggestion_panel.scss #190920
    Team:Visualizations
  36. CSS Deprecation Issue for Team: kibana-visualizations, Found in file: toolbar_button.scss #190921
    Team:Visualizations
  37. CSS Deprecation Issue for Team: kibana-visualizations, Found in file: tooltip.scss #190922
    Team:Visualizations
  38. CSS Deprecation Issue for Team: kibana-visualizations, Found in file: visualization_container.scss #190923
    Team:Visualizations
  39. CSS Deprecation Issue for Team: kibana-visualizations, Found in file: visualize_editor.scss #190924
    Team:Visualizations
  40. CSS Deprecation Issue for Team: kibana-visualizations, Found in file: workspace_panel_wrapper.scss #190925
    Team:Visualizations
  41. [ML] CSS Deprecation Issue for Team: ml-ui, Found in file: help_popover.scss #190926
    :ml Team:ML good first issue v8.16.0
    rbrtj
  42. CSS Deprecation Issue for Team: response-ops, Found in file: add_message_variables.scss #190927
    Team:ResponseOps
    adcoelho
@jbudz jbudz added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Aug 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@jbudz jbudz changed the title Fix SASS deprecation warnings Fix SASS mixed-declations deprecation warnings Aug 12, 2024
@jbudz jbudz mentioned this issue Aug 12, 2024
Merged
jbudz added a commit that referenced this issue Aug 12, 2024
@jbudz
[optimizer] Mute SASS mixed-decls warnings (#190348)
8e99daf 
These are impacting DX. Remediation will be tracked at
#190345.

## Testing

`node scripts/build_kibana_platform_plugins` and `yarn start` should not
log warnings about the `mixed-decls` sass rule
bryce-b pushed a commit to bryce-b/kibana that referenced this issue Aug 13, 2024
@jbudz @bryce-b
[optimizer] Mute SASS mixed-decls warnings (elastic#190348)
5efadd0 
These are impacting DX. Remediation will be tracked at
elastic#190345.

## Testing

`node scripts/build_kibana_platform_plugins` and `yarn start` should not
log warnings about the `mixed-decls` sass rule
@Ikuni17 Ikuni17 mentioned this issue Sep 11, 2024
Merged
Ikuni17 added a commit that referenced this issue Sep 11, 2024
@Ikuni17
[Storybook] Mute SASS mixed-decls warnings (#192648)
94411c5 
## Summary

This extends #190348 to the Storybook build because it is quite noisy
there as well. Example:


https://buildkite.com/elastic/kibana-pull-request/builds/233585#0191e2ad-bc90-45f1-b375-959f3fc22b98/268-294

Remediation will be tracked at
#190345

### Testing
The Storybook build step should not have SASS deprecation warnings.
gergoabraham pushed a commit to gergoabraham/kibana that referenced this issue Sep 13, 2024
@Ikuni17 @gergoabraham
[Storybook] Mute SASS mixed-decls warnings (elastic#192648)
3b817bb 
## Summary

This extends elastic#190348 to the Storybook build because it is quite noisy
there as well. Example:


https://buildkite.com/elastic/kibana-pull-request/builds/233585#0191e2ad-bc90-45f1-b375-959f3fc22b98/268-294

Remediation will be tracked at
elastic#190345

### Testing
The Storybook build step should not have SASS deprecation warnings.
markov00 pushed a commit to markov00/kibana that referenced this issue Sep 18, 2024
@Ikuni17 @markov00
[Storybook] Mute SASS mixed-decls warnings (elastic#192648)
f05ae6d 
## Summary

This extends elastic#190348 to the Storybook build because it is quite noisy
there as well. Example:


https://buildkite.com/elastic/kibana-pull-request/builds/233585#0191e2ad-bc90-45f1-b375-959f3fc22b98/268-294

Remediation will be tracked at
elastic#190345

### Testing
The Storybook build step should not have SASS deprecation warnings.
@markov00 markov00 mentioned this issue Sep 24, 2024
Merged
@jbudz jbudz mentioned this issue Oct 4, 2024
Merged
jbudz added a commit that referenced this issue Oct 4, 2024
@jbudz
Revert Mute SASS mixed-decls warnings (#195128)
f582423 
Reverts #190348 and #192648

Related to #190345
@jbudz jbudz closed this as completed Oct 4, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 4, 2024
@jbudz
Revert Mute SASS mixed-decls warnings (elastic#195128)
b4d1a99 
Reverts elastic#190348 and elastic#192648

Related to elastic#190345

(cherry picked from commit f582423)
tiansivive pushed a commit to tiansivive/kibana that referenced this issue Oct 7, 2024
@jbudz @tiansivive
Revert Mute SASS mixed-decls warnings (elastic#195128)
211712b 
Reverts elastic#190348 and elastic#192648

Related to elastic#190345
tiansivive pushed a commit to tiansivive/kibana that referenced this issue Oct 7, 2024
@jbudz @tiansivive
Revert Mute SASS mixed-decls warnings (elastic#195128)
61871c4 
Reverts elastic#190348 and elastic#192648

Related to elastic#190345
@mistic mistic mentioned this issue Oct 8, 2024
Draft
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbudz jbudz

@petrklapka petrklapka

Labels
Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbudz @elasticmachine @petrklapka