Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nested table split in data table visualization #24560

Closed
timroes opened this issue Oct 25, 2018 · 1 comment · Fixed by #26057
Closed

Remove nested table split in data table visualization #24560

timroes opened this issue Oct 25, 2018 · 1 comment · Fixed by #26057
Assignees
Labels
enhancement New value added to drive a business result Feature:Data Table Data table visualization feature release_note:breaking Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@timroes
Copy link
Contributor

timroes commented Oct 25, 2018

With an upcoming major version we are going to remove nested table splits in the data table visualization.

Currently a user has the possibility to create multiple "Split table" aggregations in one table on arbitrary levels (before Split columns, or after or in between them). This requires us to render tables inside table cells inside other tables...

Since this feature has a couple of drawbacks, including horrible accessibility due to nested tables, large technical maintenance burden, a complex implementation, and very weird UX if you try putting Split Tables after Split Row buckets, we decided to align splitting of tables with all other charts in Kibana. Meaning we will only allow on Split Table bucket as the top most bucket aggregation. This change won't change anything about the amount of Split Rows a user can put into a table.

This change is in preparation for #16639.

When migrating saved objects towards that new implementation, we will convert every non first level Split Table bucket into a Split Row bucket instead, so no saved object will be destroyed, they will just render differently.

@timroes timroes added release_note:breaking Feature:Data Table Data table visualization feature enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 25, 2018
@timroes
Copy link
Contributor Author

timroes commented Oct 25, 2018

cc @lukeelmers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Data Table Data table visualization feature release_note:breaking Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants