Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite table visualization in React/EUI #16639

Closed
9 of 20 tasks
timroes opened this issue Feb 9, 2018 · 3 comments
Closed
9 of 20 tasks

Rewrite table visualization in React/EUI #16639

timroes opened this issue Feb 9, 2018 · 3 comments
Labels
Feature:Data Table Data table visualization feature Meta Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@timroes
Copy link
Contributor

timroes commented Feb 9, 2018

Table Vis Rewrite

We need to rewrite the Table visualization in React. This means we should convert the Angular agg_table directive to React using the EUI components.

TODO This issue is out-dated and need to be updated, once we start working on the table vis reactification again.

Prerequisites / Blockers

Tasks

Other

@timroes timroes added chore Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Feature:Data Table Data table visualization feature labels Feb 9, 2018
@timroes timroes self-assigned this Feb 9, 2018
@lukeelmers lukeelmers assigned lukeelmers and unassigned timroes Sep 7, 2018
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Sep 16, 2018
@lukeelmers lukeelmers assigned myasonik and unassigned lukeelmers Jun 28, 2019
@timroes timroes added Meta and removed chore labels Jul 4, 2019
@majagrubic
Copy link
Contributor

majagrubic commented Nov 27, 2019

I was doing a Kibana Data Analyst training just now, and noticed a weird pattern when sorting the DataTable. It turns out we have 3 ways of sorting things: ascending, descending and natural (the way it was returned from ES). The title of the column also doesn't change when the sorting changes (eg. if I change it from Descending to Ascending, I would expect that to reflect in the column title).
I believe this pattern is very confusing, it was not obvious to me nor to the other attendants of the training. Can we somehow make this more obvious during the rewrite?

sorting

@myasonik
Copy link
Contributor

@majagrubic Yup! The table will be moving to EuiDataGrid which has a much more robust way of handling sorting!

@timroes
Copy link
Contributor Author

timroes commented May 13, 2020

Replaced by #64444

@timroes timroes closed this as completed May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Table Data table visualization feature Meta Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants