Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accessibility] Spaces List Edit and Delete Buttons need more context #27744

Closed
aphelionz opened this issue Dec 23, 2018 · 1 comment
Closed

[Accessibility] Spaces List Edit and Delete Buttons need more context #27744

aphelionz opened this issue Dec 23, 2018 · 1 comment
Assignees
@legrego
Labels
Feature:Security/Spaces Platform Security - Spaces feature Project:Accessibility Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! WCAG A

Comments

@aphelionz
Copy link
Contributor

Steps to reproduce (assumes ChromeVox or similar)

  1. Open /app/kibana#/management/spaces/list
  2. Tab to the "edit" and "delete buttons on any row

screenshot_20181223_113855

Actual Result, Respectively

"Edit"
"Delete"

Expected Result

"Edit [insert human-readable name of current space]"
"Delete [insert human-readable name of current space]"

Kibana Version:
Relevant WCAG Criteria: 3.3.2 Labels or Instructions https://www.w3.org/WAI/WCAG21/quickref/#labels-or-instructions
Meta Issue: #25512
@aphelionz aphelionz mentioned this issue Dec 23, 2018
Closed
9 tasks
@aphelionz aphelionz added Project:Accessibility Feature:Security/Spaces Platform Security - Spaces feature labels Dec 23, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

@kobelb kobelb added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Jan 2, 2019
@legrego legrego mentioned this issue Jan 2, 2019
Merged
@legrego legrego self-assigned this Jan 2, 2019
legrego added a commit to legrego/kibana that referenced this issue Jan 3, 2019
@legrego
Provides context to spaces grid action buttons (elastic#27911)
e174ddd 
## Summary
Fixes elastic#27744

cc @elastic/eui-design -- It appears that the [`DefaultItemAction`](https://elastic.github.io/eui/#/display/tables) can only accept hard-coded `name`/`description` values. While this isn't necessarily a bad thing, I'm wondering if the linked issue (elastic#27744) will be a common enough occurrence within Kibana to make the DefaultItemAction less useful. What do you think about allowing functions for the `name` and `description` fields, so that they can get access to the row's record, and provide context as necessary?
legrego added a commit to legrego/kibana that referenced this issue Jan 3, 2019
@legrego
Provides context to spaces grid action buttons (elastic#27911)
33ec9a3 
## Summary
Fixes elastic#27744

cc @elastic/eui-design -- It appears that the [`DefaultItemAction`](https://elastic.github.io/eui/#/display/tables) can only accept hard-coded `name`/`description` values. While this isn't necessarily a bad thing, I'm wondering if the linked issue (elastic#27744) will be a common enough occurrence within Kibana to make the DefaultItemAction less useful. What do you think about allowing functions for the `name` and `description` fields, so that they can get access to the row's record, and provide context as necessary?
legrego added a commit that referenced this issue Jan 3, 2019
@legrego
Provides context to spaces grid action buttons (#27911)
36d0f4a 
## Summary
Fixes #27744

cc @elastic/eui-design -- It appears that the [`DefaultItemAction`](https://elastic.github.io/eui/#/display/tables) can only accept hard-coded `name`/`description` values. While this isn't necessarily a bad thing, I'm wondering if the linked issue (#27744) will be a common enough occurrence within Kibana to make the DefaultItemAction less useful. What do you think about allowing functions for the `name` and `description` fields, so that they can get access to the row's record, and provide context as necessary?
legrego added a commit to legrego/kibana that referenced this issue Jan 3, 2019
@legrego
Provides context to spaces grid action buttons (elastic#27911)
a3bc804 
Fixes elastic#27744

cc @elastic/eui-design -- It appears that the [`DefaultItemAction`](https://elastic.github.io/eui/#/display/tables) can only accept hard-coded `name`/`description` values. While this isn't necessarily a bad thing, I'm wondering if the linked issue (elastic#27744) will be a common enough occurrence within Kibana to make the DefaultItemAction less useful. What do you think about allowing functions for the `name` and `description` fields, so that they can get access to the row's record, and provide context as necessary?
legrego added a commit that referenced this issue Jan 3, 2019
@legrego
Provides context to spaces grid action buttons (#27911) (#28005)
e6bbaac 
## Summary
Fixes #27744

cc @elastic/eui-design -- It appears that the [`DefaultItemAction`](https://elastic.github.io/eui/#/display/tables) can only accept hard-coded `name`/`description` values. While this isn't necessarily a bad thing, I'm wondering if the linked issue (#27744) will be a common enough occurrence within Kibana to make the DefaultItemAction less useful. What do you think about allowing functions for the `name` and `description` fields, so that they can get access to the row's record, and provide context as necessary?
legrego added a commit that referenced this issue Jan 4, 2019
@legrego
Provides context to spaces grid action buttons (#27911) (#28009)
07b1d48 
Fixes #27744

cc @elastic/eui-design -- It appears that the [`DefaultItemAction`](https://elastic.github.io/eui/#/display/tables) can only accept hard-coded `name`/`description` values. While this isn't necessarily a bad thing, I'm wondering if the linked issue (#27744) will be a common enough occurrence within Kibana to make the DefaultItemAction less useful. What do you think about allowing functions for the `name` and `description` fields, so that they can get access to the row's record, and provide context as necessary?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@legrego legrego

Labels
Feature:Security/Spaces Platform Security - Spaces feature Project:Accessibility Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! WCAG A
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@aphelionz @kobelb @legrego @elasticmachine @rayafratkina