Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Discover, Visualize, and Dashboard apps to date picker in QueryBar #29674

Closed
nreese opened this issue Jan 31, 2019 · 2 comments
Closed
Assignees
Labels
blocker Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.0.0

Comments

@nreese
Copy link
Contributor

nreese commented Jan 31, 2019

#29235 integrated the date picker into QueryBar. The date picker is turned on by passing in the props showDatePicker, dateRangeFrom, dateRangeTo, isRefreshPaused, refreshInterval, and onRefreshChange. Now, onSubmit is called with query and dateRange so instead of subscribing to time changes with ui/timefilter, the apps should receive the time changes from onSubmit callback.

Discover, Visualize, and Dashboard applications need to switch from using the angular date picker in kbn_top_nav to using the date picker in the query bar.

          <query-bar
              query="query"
              app-name="'maps'"
              on-submit="updateQueryAndDispatch"
              index-patterns="indexPatterns"
              show-date-picker="showDatePicker"
              date-range-from="time.from"
              date-range-to="time.to"
              is-refresh-paused="refreshConfig.isPaused"
              refresh-interval="refreshConfig.interval"
              on-refresh-change="onRefreshChange"
            ></query-bar>

The Maps application has been migrated and can be used as an example application

screen shot 2019-01-30 at 5 07 15 pm

.
@nreese nreese added blocker v7.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 31, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@stacey-gammon
Copy link
Contributor

@rayafratkina - any luck finding someone else to pick this up or is @Bargs still planning to tackle it after the Default to KQL work?

Sounds like this is a blocker for Feature Freeze and it's not going in today?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.0.0
Projects
None yet
Development

No branches or pull requests

5 participants