Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking refresh button in Kibana top nav time picker does not cause refresh #30179

Closed
nreese opened this issue Feb 6, 2019 · 3 comments
Closed
Labels
bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.0.1

Comments

@nreese
Copy link
Contributor

nreese commented Feb 6, 2019

timefilter.setTime only emits the events timeUpdate and fetch when called with a new time. Pressing the refresh button does not cause these events to be emitted because the time did not change.

This issue will be less visible once #29674 is complete and the time picker in the global nav is no longer used for discover, visualize, and dashboard.

screen shot 2019-02-05 at 8 40 23 pm

@nreese nreese added bug Fixes for quality problems that affect the customer experience v7.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 6, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@nreese
Copy link
Contributor Author

nreese commented Feb 6, 2019

I tried moving the fetch emit event outside of the areTimePickerValsDifferent but this broke dashboard cancel edit and reverting to old state (specifically the case tested by this functional test https://github.com/elastic/kibana/blob/master/test/functional/apps/dashboard/_view_edit.js#L121 - where you edit a dashboard, add a panel, cancel the changes, and the added panel should be removed).

@nreese
Copy link
Contributor Author

nreese commented Oct 19, 2019

This has been resolved now

@nreese nreese closed this as completed Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.0.1
Projects
None yet
Development

No branches or pull requests

3 participants