Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite discover's doc_table \ doc_viewer in React/EUI #34233

Closed
6 tasks
lizozom opened this issue Mar 31, 2019 · 2 comments
Closed
6 tasks

Rewrite discover's doc_table \ doc_viewer in React/EUI #34233

lizozom opened this issue Mar 31, 2019 · 2 comments
Labels
chore Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0

Comments

@lizozom
Copy link
Contributor

lizozom commented Mar 31, 2019

We need to rewrite the Table visualization in React. This means we should convert the Angular doc_table and doc_table directives to React using the EUI components.

Tasks

  • Write doc_table view using React
  • Write doc_viewer view using React (used in discover and context)
  • Might utilize the new Table component ?
  • Deprecate ui/pager
  • Deprecate ui/pager_control
  • Implement inifinite scroll behavior and deprecate infinite_scroll directive
@lizozom lizozom added chore Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 labels Mar 31, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@lizozom lizozom changed the title Rewrite discover's doc_table in React/EUI Rewrite discover's doc_table \ doc_viewer in React/EUI Mar 31, 2019
@timroes
Copy link
Contributor

timroes commented Jun 11, 2019

The new discover (in React) same as the new data table visualization in React will instead of relying on their own table implementations use the (yet to be built) Dategrid component in EUI (see elastic/eui#1689). That means we can then throw away all table implementation (and directives belonging to them) in Kibana 🎉

We are also tracking process of other components (like the doc viewer mentioned above and more) that need to be rewritten in React in #38242.

I would close this issue in favor of #38242.

@timroes timroes closed this as completed Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0
Projects
None yet
Development

No branches or pull requests

3 participants