Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in time picker update button label #43675

Closed
chrisronline opened this issue Aug 21, 2019 · 4 comments · Fixed by #43799
Closed

Typo in time picker update button label #43675

chrisronline opened this issue Aug 21, 2019 · 4 comments · Fixed by #43799
Labels
bug Fixes for quality problems that affect the customer experience Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@chrisronline
Copy link
Contributor

https://github.com/elastic/kibana/blob/master/src/core/public/i18n/i18n_service.tsx#L337

It should read Update.
@chrisronline chrisronline added bug Fixes for quality problems that affect the customer experience Project:i18n labels Aug 21, 2019
@chrisronline
Copy link
Contributor Author

Looks like this was introduced by #42858 from @snide

@chrisronline chrisronline added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. and removed Project:i18n labels Aug 21, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design

@snide
Copy link
Contributor

snide commented Aug 22, 2019

I am super confused to how this one happened. Looks like our strings are correct on the EUI side. We do see a change for 13.3.0 against that label, but it looks correct.

https://elastic.github.io/eui/#/package/i18n-tokens

image

@snide
Copy link
Contributor

snide commented Aug 22, 2019 •
edited
Loading

Figured it out. Setting up a PR quick.

snide added a commit to snide/kibana that referenced this issue Aug 22, 2019
@snide
typo in update button. fixes elastic#43675
e87d0ca
@snide snide mentioned this issue Aug 22, 2019
Merged
snide added a commit that referenced this issue Aug 22, 2019
@snide
Typo in update button. fixes #43675 (#43799)
37dc421 
Fixes the update button text.
@snide snide mentioned this issue Aug 22, 2019
Merged
snide added a commit to snide/kibana that referenced this issue Aug 22, 2019
@snide
Typo in update button. fixes elastic#43675 (elastic#43799)
829c595 
Fixes the update button text.
snide added a commit that referenced this issue Aug 23, 2019
@snide
Typo in update button. fixes #43675 (#43799) (#43823)
eea7658 
Fixes the update button text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

typo in update button. fixes #43675 snide/kibana
3 participants
@chrisronline @snide @elasticmachine