Suggestion: Alerts dialogue should be unique #442
Comments
harper-carroll
pushed a commit
to harper-carroll/kibana
that referenced
this issue
Jul 11, 2016
…ddHighThroughPut Revert "Revert "Add high through put""
w33ble
pushed a commit
to w33ble/kibana
that referenced
this issue
Sep 13, 2018
* unit tests for altercolumn * unit tests for as * Added tests for as * fixed typo * Refactored alterColumn to not mutate context. Updated unit tests for altercolumn * Updated unit tests for as * Updated altercolumn to return original context when name and type are not provided as args * Added unit tests for columns. Refactored columns function to return empty array of rows if columns is empty instead of an array of empty objects * Changed describe from 'as' to 'columns' * Unit tests for getCell. Added throw for invalid column in getCell * Unit tests for head * Added functionWrapper that fills in default args * fixed merge conflict * Added default name for as function. Added unit test for as * Updated tests for getCell and head * Cleaned up unit tests for alterColumn * Updated unit tests for as * Cleaned up tests for columns * Cleaned up tests for getCell * Cleaned up tests for head * Added unit tests for tail * Unit tests for rowCount * Added throw for missing column name and default for value in staticColumn. Added unit tests for staticColumn * Removed .only from unit tests for rowCount * Fixed typo * Removed jsonquery function. Moving to canvas-extras * Added alias for args._ in sort and removed aliases key from function definition * Added logic to sort on first column by default if column isn't provided as an arg. Added unit tests for sort * Added test for staticColumn * Added throw for missing column name. Refactored mapColumn to not mutate context. Added unit tests for mapColumn * Merged functionWrapper from common-tests * Removed compare unit tests from this branch. Unit tests for compare are in PR elastic#415 * WIP: unit tests for ply * WIP: unit tests for ply * Fixed tests for mapColumn * Added unit tests for ply. Add checks for missing args in ply * Fixed unit tests for ply * Changed functionWrapper to function_wrapper and fixed import paths. Removed .js extension in imports. * Added check for column arg in alterColumn. Cleaned up tests for alterColumn * Cleaned up tests for alterColumn and as * Added tests to alterColumn * Cleaned up columns tests * Cleaned up getCell tests * Cleaned up tests for head and tail * Cleaned up mapColumn tests * Cleaned up tests for mapColumn, ply, and sort * Cleaned up tests for staticColumn * Cleaned up tests * Fixed jquery version * Changed alterColumn, mapColumn, and staticColumn to overwrite existing columns if provided name of existing columns * fixed tests for ply * Fixed spacing in unit tests * Fixed typo * Condensed tests. Used '.and' where applicable. * Changed getCell to default to first column if args._ is missing
Merged
This was referenced Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems like the alerts dialogue should be unique.
A simple refresh would remove them, but perhaps alert state could be saved such that no alert is displayed more than once if one exists and isn't dismissed. If the connection is lost from moving between network access points or by other means, it can be quite a nuisance to dismiss all of them.
The text was updated successfully, but these errors were encountered: