Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Watcher] Unskip component integration tests #52620

Closed
jloleysens opened this issue Dec 10, 2019 · 2 comments
Closed

[Watcher] Unskip component integration tests #52620

jloleysens opened this issue Dec 10, 2019 · 2 comments
Labels
chore Feature:Watcher Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@jloleysens
Copy link
Contributor

jloleysens commented Dec 10, 2019 •
edited
Loading

After #51145 was merged we can remove the .skip from all of the component integration tests in watcher.

Preferably only after #50908 is merged .

[Update]
Only watch conditions inside watch_create_threshold.test.tsx needs to be revived.
@jloleysens jloleysens added chore Feature:Watcher Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Dec 10, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@jloleysens jloleysens mentioned this issue Dec 10, 2019
Merged
@alisonelizabeth
Copy link
Contributor

Most of the tests were unskipped as part of #88225

There are still some flaky tests, tracked via #163532

@alisonelizabeth alisonelizabeth closed this as not planned Won't fix, can't repro, duplicate, stale Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Feature:Watcher Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alisonelizabeth @jloleysens @elasticmachine