[Watcher] Update skipped jests tests #88225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonelizabeth
added
chore
Feature:Watcher
v8.0.0
Team:Kibana Management
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
alisonelizabeth
commented
Jan 14, 2021
| @@ -119,7 +119,7 @@ export class WatchStatus { | |||
| } | |||
|
|
|||
| get lastFired() { | |||
| const actionStatus = max(this.actionStatuses, 'lastExecution'); | |||
| const actionStatus = maxBy(this.actionStatuses, 'lastExecution'); | |||
There was a problem hiding this comment.
This appears to be an actual bug that the test caught. I don't see how this was working before based on the lodash documentation.
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
sebelga
approved these changes
Jan 14, 2021
| @@ -119,7 +119,7 @@ export class WatchStatus { | |||
| } | |||
|
|
|||
| get lastFired() { | |||
| const actionStatus = max(this.actionStatuses, 'lastExecution'); | |||
| const actionStatus = maxBy(this.actionStatuses, 'lastExecution'); | |||
alisonelizabeth
added
the
release_note:skip
alisonelizabeth
added a commit
that referenced
this pull request
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87691
Some of the watcher tests were recently converted to jest via #87599. As part of that work, it was revealed that not all tests had been running in CI previously. Some of the tests were failing as-is and skipped. This PR addresses any issues and all watcher jest tests should be running now.