Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit and convert tests to jest #54339

Closed
13 of 17 tasks
flash1293 opened this issue Jan 9, 2020 · 3 comments
Closed
13 of 17 tasks

Audit and convert tests to jest #54339

flash1293 opened this issue Jan 9, 2020 · 3 comments
Assignees
Labels
Feature:NP Migration Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

flash1293 commented Jan 9, 2020

In the various visualizations and apps of the Kibana app team some tests are still using the karma setup even though they are just running regular unit tests.

All of these places should be audited whether the conversion to jest is possible and converted whether thats the case. Some tests do visual regression testing which is not possible in jest - these tests will be handled in a separate step.

  • src/legacy/core_plugins/vis_type_timeseries/server/lib/vis_data/series/__tests__
  • src/legacy/core_plugins/vis_type_timeseries/server/lib/vis_data/request_processors/series/__tests__
  • src/legacy/core_plugins/vis_type_timeseries/server/lib/vis_data/__tests__
  • src/legacy/core_plugins/vis_type_timeseries/server/lib/vis_data/response_processors/series/__tests__
  • src/legacy/core_plugins/vis_type_timeseries/common/__tests__
  • src/legacy/core_plugins/input_control_vis/public/components/editor/__tests__
  • src/legacy/core_plugins/vis_type_vega/public/data_model/__tests__
  • src/legacy/core_plugins/vis_type_timeseries/public/components/lib/__tests__
  • src/legacy/core_plugins/vis_type_timelion/public/
  • src/legacy/core_plugins/kibana/public/dashboard/__tests__
  • src/legacy/core_plugins/vis_type_table/public/agg_table/__tests__
  • src/legacy/core_plugins/vis_type_metric/public/metric_vis_type.test.ts (this is already jest, but relies on ui/new_platform - should be made a real unit test)

Low priority, should be redundant with #47559 :

  • src/legacy/core_plugins/kibana/public/discover/np_ready/angular/context/api/utils/__tests__
  • src/legacy/core_plugins/kibana/public/discover/np_ready/angular/context/api/__tests__
  • src/legacy/core_plugins/kibana/public/discover/__tests__

Next tests contains visual testing, covered by separate issue: #57813

  • src/legacy/core_plugins/vis_type_tagcloud/public/components/__tests__
  • src/legacy/core_plugins/vis_type_vega/public/__tests__
@flash1293 flash1293 added Feature:NP Migration Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal
Copy link
Member

kertal commented Jul 30, 2020

think we can close this, dear @flash1293 ?

@flash1293
Copy link
Contributor Author

You are right, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:NP Migration Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants