Trigger selection

[streamich]

Add ability to pick trigger in <FormCreateDrilldown> and <FormEditDrilldown>.

1. We need to decide if visualizations will have more than one trigger.
2. Even if visualizations support just one trigger, other teams need ability to pick a trigger.

• Make Trigger extend Presentable interface.
• Create presentational <TriggerPicker> component
• Add a triggers prop—which is a list of triggers, from which one will be selected—to:
  • <FormCreateDrilldown>
  • <FormEditDrilldown>
• Embeddables
  • Add ability to embeddables to report their supported triggers. (in progress) Embeddable triggers #58440
  • In visualize_embeddable report correct triggers for each vis_type in supportedTriggers() method.
  • Pass triggers that embeddable supports though triggers prop to above React components.

Parent issue: #42845

[elasticmachine]

Pinging @elastic/kibana-app-arch (Team:AppArch)

[Dosant]

This is needed for URL drilldown to pick from ValueClickTrigger & SelectRangeTrigger.

Assumption is that user picks drilldown type first and then, if > 1 trigger is available, also picks a trigger :
I implemented this in POC, but need @mdefazio help to make it nice:

Picked trigger also should be somehow visible on "manage" screen:

[mdefazio]

Some questions for the functionality:

• Do I need to be able to choose one or the other or both (depending on the chart type)?
• (Again, depending on chart type), are either or both of these disabled (or not shown)?
• Guessing we can show this on the same screen as the rest of the drilldown form instead of an additional step
• This is for 7.10, correct?

[Dosant]

@mdefazio

Do I need to be able to choose one or the other or both (depending on the chart type)?

Depending on a chart type and on a type of picked drilldown we will show available triggers.

• if only 1 is available, then it is going to be preselected and no user interaction needed
• if more then 1 is available, then needs to be explicitly picked.

At first there would be such scenario:

1. When I pick a dashboard drilldown, then no trigger picker selection is needed. (dashboard drilldown will support only 1 high level trigger "Apply_filter_trigger")
2. When I pick a url drilldown, then I also have to specify a trigger (either "click" or "select")

(Again, depending on chart type), are either or both of these disabled (or not shown)

Hm, easier would be to not show. But showing as disabled also possible.

Guessing we can show this on the same screen as the rest of the drilldown form instead of an additional step

Possible triggers will also depend on a drill down type.

So it have to be:

1. Pick a drilldown type first
2. Only then we can show list of available triggers. (Or don't show triggers and continue with the only available 1)

This is for 7.10, correct?

Yes!

[Dosant]

Latest I have from @mdefazio

[mdefazio]

Here are the updates mockups as discussed today

EUI component for the trigger picker can be found here near bottom of the page.

@Dosant , I think these are correct per our conversation. Let me know if I'm missing something though.

[mdefazio]

These could also use a review from @gchaps for the copy—specifically around the descriptions for Visualization vs Panel Menu (and maybe those names could be better) as well as Single Click / Range Selection

[gchaps]

@mdefazio Happy to help, but I need more context. Does "Visualization" add data based on a user interaction?

[Dosant]

Oops, pr closed this. I am reopening to finalise user facing texts

[mdefazio]

Spoke with @gchaps and we updated the copy for the Phase I mockups. Copy is still under discussion for Phase II

Updated copy included in mockups (tooltip included for 'What's this?'):

[Dosant]

@mdefazio, thanks! I will follow update it in next pr (URL drilldown one)