Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize embeddable dynamic supported triggers #75141

Closed
Dosant opened this issue Aug 17, 2020 · 2 comments
Closed

Visualize embeddable dynamic supported triggers #75141

Dosant opened this issue Aug 17, 2020 · 2 comments
Labels
enhancement New value added to drive a business result Feature:Embedding Embedding content via iFrame Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@Dosant
Copy link
Contributor

Dosant commented Aug 17, 2020

Originally noticed by @ThomThomson: #74751 (review)
This is probably not a big deal, but it worth creating an issue

With introduction of #59569 drilldowns will allow to pick a trigger to attach to. Also drilldowns will be allowed created only in case there is an existing drilldown type which supports at least 1 trigger from an embeddable.

In some cases visualize embeddable provide larger list of triggers which is actually available, for instance:

  • A vislib bar chart where the x-axis uses a terms aggregation. In this case, the embeddable doesn't allow brushing, but still allows the 'range select' drilldowns to be added. When you add a drilldown in this state, it is impossible to trigger it.

The list of supported trigger is static: https://github.com/elastic/kibana/blob/master/src/plugins/vis_type_vislib/public/histogram.ts#L55, but maybe we could make it dynamic depending on actual configuration.

If we improve this, we also need to keep in mind, that visualisation config can be changed after drilldown is created on one of the dashboards, and drilldown created before could possible be no longer be valid anymore due to new configuration. In this case, we at least need to make sure that UI doesn't fail completely.

@Dosant Dosant added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Feature:Embedding Embedding content via iFrame enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula
Copy link
Contributor

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Embedding Embedding content via iFrame Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants