Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Service maps popover: Change the errors per minute to error rate #68160

Closed
formgeist opened this issue Jun 3, 2020 · 2 comments · Fixed by #69520
Closed

[APM] Service maps popover: Change the errors per minute to error rate #68160

formgeist opened this issue Jun 3, 2020 · 2 comments · Fixed by #69520
Assignees
@smith
Labels
apm:service-maps Service Map feature in APM enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support v7.9.0

Comments

@formgeist
Copy link
Contributor

formgeist commented Jun 3, 2020 •
edited
Loading

Summary

We're switching from errors per minute to error rate to give a more precise indication of the number of errors compared to transactions to see a decrease in performance. We want to make this change across all our views.

Solution

Change the errors per minute metric in the service map node popover to error rate.

Screenshot 2020-06-03 at 20 50 44
@formgeist formgeist added Team:APM All issues that need APM UI Team support enhancement New value added to drive a business result apm:service-maps Service Map feature in APM v7.9.0 labels Jun 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@formgeist formgeist self-assigned this Jun 10, 2020
@formgeist formgeist removed their assignment Jun 11, 2020
@smith smith self-assigned this Jun 15, 2020
@smith smith assigned smith and unassigned smith Jun 15, 2020
@formgeist
Copy link
Contributor Author

@smith I think I missed this in the design, but it should say "Error rate (avg.)" like the others.

smith added a commit to smith/kibana that referenced this issue Jun 18, 2020
@smith
[APM] Add error rates to Service Map popovers
f07d9fb 
Make the `getErrorRate` function used in the error rate charts additionally take `service.environment` as a filter and have it return the `average` of the values.

Call that function in the API for the service map metrics.

Fixes elastic#68160.
@smith smith mentioned this issue Jun 18, 2020
Merged
smith added a commit that referenced this issue Jul 15, 2020
@smith @cauemarcondes
[APM] Add error rates to Service Map popovers (#69520)
f69edbd 
Make the `getErrorRate` function used in the error rate charts additionally take `service.environment` as a filter and have it return the `average` of the values.

Call that function in the API for the service map metrics.

Fixes #68160.

Co-authored-by: cauemarcondes <[email protected]>
smith added a commit to smith/kibana that referenced this issue Jul 15, 2020
@smith @cauemarcondes
[APM] Add error rates to Service Map popovers (elastic#69520)
914da91 
Make the `getErrorRate` function used in the error rate charts additionally take `service.environment` as a filter and have it return the `average` of the values.

Call that function in the API for the service map metrics.

Fixes elastic#68160.

Co-authored-by: cauemarcondes <[email protected]>
smith added a commit that referenced this issue Jul 15, 2020
@smith @cauemarcondes
[APM] Add error rates to Service Map popovers (#69520) (#71855)
608309c 
Make the `getErrorRate` function used in the error rate charts additionally take `service.environment` as a filter and have it return the `average` of the values.

Call that function in the API for the service map metrics.

Fixes #68160.

Co-authored-by: cauemarcondes <[email protected]>

Co-authored-by: cauemarcondes <[email protected]>
smith added a commit to smith/kibana that referenced this issue Jul 16, 2020
@smith @cauemarcondes
[APM] Add error rates to Service Map popovers (elastic#69520)
a0858f7 
Make the `getErrorRate` function used in the error rate charts additionally take `service.environment` as a filter and have it return the `average` of the values.

Call that function in the API for the service map metrics.

Fixes elastic#68160.

Co-authored-by: cauemarcondes <[email protected]>
smith added a commit that referenced this issue Jul 17, 2020
@smith @cauemarcondes @elasticmachine
[APM] Add error rates to Service Map popovers (#69520) (#71994)
02b9ebc 
Make the `getErrorRate` function used in the error rate charts additionally take `service.environment` as a filter and have it return the `average` of the values.

Call that function in the API for the service map metrics.

Fixes #68160.

Co-authored-by: cauemarcondes <[email protected]>

Co-authored-by: cauemarcondes <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smith smith

Labels
apm:service-maps Service Map feature in APM enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Add error rates to Service Map popovers smith/kibana
4 participants
@smith @sorenlouv @formgeist @elasticmachine