Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Remove epm feature flag #68658

Closed
mostlyjason opened this issue Jun 9, 2020 · 6 comments · Fixed by #71542
Closed

[Ingest Manager] Remove epm feature flag #68658

mostlyjason opened this issue Jun 9, 2020 · 6 comments · Fixed by #71542
Assignees
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@mostlyjason
Copy link
Contributor

Currently, we have a feature flag in kibana to enable EPM. However, we don't tell customers what EPM is and it's not shown in the UI anywhere. Its a little confusing what that is referring to. We should remove the flag or make it more clear what it's referring to.

#66736

@mostlyjason mostlyjason added Team:Fleet Team label for Observability Data Collection Fleet team Ingest Management:beta1 labels Jun 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@ruflin
Copy link
Member

ruflin commented Jun 10, 2020

++ on removing the flag altogether.

@jen-huang jen-huang changed the title [Ingest Manager] Rename epm feature flag [Ingest Manager] Remove epm feature flag Jun 11, 2020
@jen-huang
Copy link
Contributor

@ph @mostlyjason Hi, in addition to xpack.ingestManager.epm.enabled, we also have xpack.ingestManager.epm.registryUrl setting which has the same confusing usage of "epm". I suggest to:

  1. Remove EPM enabled flag
  2. Flatten the registry url flag to xpack.ingestManager.registryUrl

What do you think?

@ph
Copy link
Contributor

ph commented Jul 13, 2020

+1 for the proposal. We might to update the docs with that new flag.

@mostlyjason
Copy link
Contributor Author

+1

@jen-huang
Copy link
Contributor

Thanks everyone for the quick consensus. This wasn't a high priority in our backlog, but if a user has invalid/unknown settings in their config, Kibana will fail to start. I opened a PR for this change to avoid this kind of breaking change after beta release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants