Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Remove epm config options #71542

Merged
merged 2 commits into from
Jul 13, 2020

Conversation

jen-huang
Copy link
Contributor

Summary

Resolves #68658. This PR removes xpack.ingestManager.epm.enabled config option and all references to it in related code and docs. This PR also flattens xpack.ingestManager.epm.registryUrl to xpack.ingestManager.registryUrl and updates all references.

@jen-huang jen-huang added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 13, 2020
@jen-huang jen-huang requested a review from a team July 13, 2020 20:57
@jen-huang jen-huang self-assigned this Jul 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@jfsiii jfsiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Probably safer too since we never detailedt/tested the disabled EPM setting

@jen-huang jen-huang merged commit 3d5afa9 into elastic:master Jul 13, 2020
@jen-huang jen-huang deleted the ingest/rm-epm-config branch July 13, 2020 23:21
jen-huang added a commit that referenced this pull request Jul 14, 2020
* Remove `epm.enabled`, flatten `epm.registryUrl`

* Update docs
# Conflicts:
#	x-pack/plugins/ingest_manager/server/plugin.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ingest Manager] Remove epm feature flag
4 participants