Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] Replace indexpattern input text with a combobox #80849

Closed
stratoula opened this issue Oct 16, 2020 · 7 comments · Fixed by #92812
Closed

[TSVB] Replace indexpattern input text with a combobox #80849

stratoula opened this issue Oct 16, 2020 · 7 comments · Fixed by #92812
Assignees
Labels
enhancement New value added to drive a business result Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

stratoula commented Oct 16, 2020

Describe the feature:
Right now, if a user wants to use a non-default index pattern on TSVB, she should type the name exactly as it is. There is no way for the user to search and choose from the existing ones. This is a bad UX as the user should remember the index pattern which is quite difficult especially if there are many index patterns.

Screenshot 2020-10-16 at 6 23 03 PM

We would like to change this and replace the simple input text with a combobox where the user could either choose from the list of index patterns or type freely the index pattern she wants.

@stratoula stratoula added Feature:TSVB TSVB (Time Series Visual Builder) enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula stratoula assigned stratoula and unassigned stratoula Oct 19, 2020
@alexwizp alexwizp self-assigned this Nov 4, 2020
@alexwizp
Copy link
Contributor

alexwizp commented Nov 4, 2020

@stratoula do you think how we should support user input for multiple indexes?

My curiosity was caused by this issue #82438. If in the future we want to use SearchSource in TSVB, then it probably makes sense to allow users to enter only one index. On the other hand TSVB works fine with several low-level indexes splitted by comma

IMO for now the best option should looks like:
image

but how it's related to our plans?

@timroes any ideas?

@stratoula
Copy link
Contributor Author

I don't think that we should change the current way that TSVB works for now so I think that what you propose is the right way that we should go. About supporting index patterns on TSVB it is something that is under discussion and imho we shouldn't do such a huge change on TSVB. I would love Tim's feedback on this though.

@timroes
Copy link
Contributor

timroes commented Nov 5, 2020

We should imho only allow a single selection in the searchbox. The user can still enter an index pattern using comma as mentioned above, but there will be (especially when we leverage information from the index patterns) be a huge difference between using two index patterns or one with comma separated. Thus I think this combobox should be single selection only.

alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 5, 2020
alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 5, 2020
@alexwizp
Copy link
Contributor

alexwizp commented Nov 5, 2020

@timroes I don't understand a benefits of your approach. In case if user decided to select 2 indexes he/she doesn't have any way to do without typing value using keyboard. Single selection mode overrides the previous value.

I suggest to allow users to input custom index patterns if they need it and think about using multi selection mode. From my point of view it's right from the UX perspective.

You can test how it works here: #82696

@timroes
Copy link
Contributor

timroes commented Nov 5, 2020

I agree that this might from a user perspective be the better solution, I just don't think we should do it before we're not having a clearer vision for index patterns in Kibana. The order of indexes in an index pattern matters to finding it later (i.e. the indexpattern foo-*,bar-* can be a different one than bar-*,foo-*). Since I suspect that we'll need to make some matching on those if we would go into index patterns in TSVB, I find it missleading showing them as foo-* bar-*, since we hide an explicit order more - I am not even sure if the combobox guarantees us an order of the tags in general.

Also it would rise the question if we would want to split tags by "index pattern" later or by index, i.e. would we have foo-* bar-* baz-* or foo-*,baz-* bar-* in case that foo-*,baz-* index pattern exists.

So I am not saying that we should never go into the split solution, but I would prefer postponing that change in design until we're further with our plan around index patterns and until then keep the "input" as close to what we currently have, i.e. just one text, no visual splitting for the user.

@stratoula
Copy link
Contributor Author

stratoula commented Feb 22, 2021

When this #91367 is impemented, I think we should close this issue
cc @alexwizp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
4 participants