Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Generate unique ID by stream #81617

Closed
nchaulet opened this issue Oct 26, 2020 · 4 comments · Fixed by #82447
Closed

[Fleet] Generate unique ID by stream #81617

nchaulet opened this issue Oct 26, 2020 · 4 comments · Fixed by #82447
Assignees
Labels
Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0

Comments

@nchaulet
Copy link
Member

nchaulet commented Oct 26, 2020

Description

Should resolve elastic/beats#22054 (comment)

We should generate a unique ID for each stream.

This ID could be of the form ${input.type}-${packageStream.data_stream.dataset}-${input.id} and will be saved when the package policy saved object is persisted.

@nchaulet nchaulet added the Team:Fleet Team label for Observability Data Collection Fleet team label Oct 26, 2020
@nchaulet nchaulet self-assigned this Oct 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@ruflin
Copy link
Member

ruflin commented Oct 27, 2020

I remember we were thinking about using this id also for debug purpose in the future. So having some human readability as part of it would be beneficial.

@ph ph added the v7.11.0 label Oct 27, 2020
@ph
Copy link
Contributor

ph commented Oct 27, 2020

Seems to be related to the observability goals?

@nchaulet
Copy link
Member Author

nchaulet commented Nov 3, 2020

@ph yes it's related to observability having correct ids for stream and inputs there is also this issue to fix for input id #82426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants