Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Make Agent Policy inputs ids unique #82426

Closed
nchaulet opened this issue Nov 3, 2020 · 4 comments
Closed

[Fleet] Make Agent Policy inputs ids unique #82426

nchaulet opened this issue Nov 3, 2020 · 4 comments
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@nchaulet
Copy link
Member

nchaulet commented Nov 3, 2020

Description

During the effort of reporting agent status, we found that input ids are not unique, we plan to use input id to report policy status, so we should probably fix this.

Current Policy
Screen Shot 2020-11-03 at 8 12 01 AM

Possible solution

We could prefix the input id by the input type
@kevinlog Does this will impact endpoint as the input id will not match the package policy id anymore?

Screen Shot 2020-11-03 at 8 17 44 AM

@nchaulet nchaulet added Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 labels Nov 3, 2020
@nchaulet nchaulet self-assigned this Nov 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@kevinlog
Copy link
Contributor

kevinlog commented Nov 3, 2020

We could prefix the input id by the input type
@kevinlog Does this will impact endpoint as the input id will not match the package policy id anymore?

We'll need to access the package policy ID in some predictable way, so if they're prefixed, we could strip that and use it to make changes to the policy. Will this change the policy APIs in Ingest? Will we now make updates using the new input ID with the prefix?

@paul-tavares @parkiino can you also comment on the above? Any other ways you'll see it impact our UI?

@nchaulet
Copy link
Member Author

nchaulet commented Nov 3, 2020

Will this change the policy APIs in Ingest

Yes the package policy API be impacted and only accept the package policy Id as identifier /package-policies/{packagePolicyId}
I guess we can have some "magic" on our side to support both package policy id and input id but if we can avoid that.

@jen-huang
Copy link
Contributor

Resolved by #83101.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants