Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPM] Missing icons for Elasticsearch assets #88324

Closed
skh opened this issue Jan 14, 2021 · 4 comments
Closed

[EPM] Missing icons for Elasticsearch assets #88324

skh opened this issue Jan 14, 2021 · 4 comments
Assignees
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@skh
Copy link
Contributor

skh commented Jan 14, 2021

With the merge of #88036 , we now show both Kibana and Elasticsearch assets in the sidebar of the Integrations detail page:

The full list of Elasticsearch assets that can appear in this list is (from common/types/models/epm.ts):

export enum ElasticsearchAssetType {
  componentTemplate = 'component_template',
  ingestPipeline = 'ingest_pipeline',
  indexTemplate = 'index_template',
  ilmPolicy = 'ilm_policy',
  transform = 'transform',
  dataStreamIlmPolicy = 'data_stream_ilm_policy',
}

We don't have icons assigned to these asset types yet, so they currently appear without an icon in the list. This example shows only an ingest pipeline without an icon but it applies to all ES asset types:

image

This task is to:

  1. Pick correct icons for these asset types from EUI, e.g. from https://elastic.github.io/eui/#/display/icons#apps
  2. Fix the implementation so that these icons appear correctly in the UI.
@skh skh added Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team labels Jan 14, 2021
@skh skh self-assigned this Jan 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Feature:EPM)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@hbharding
Copy link
Contributor

We don't have existing icons for some of the other Elasticsearch assets, so I'm proposing we don't use icons for any Elasticsearch assets. Plus, in a future iteration, I'm planning on not using icons, even for Kibana assets. Let's close as won't fix.

@skh
Copy link
Contributor Author

skh commented Jan 14, 2021

@hbharding Thank you for looking into it!

WONTFIX it is.

@skh skh closed this as completed Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

3 participants