-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EPM] Include both kibana and elasticsearch assets in package information #88036
Conversation
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/fleet (Feature:EPM) |
Pinging @elastic/ingest-management (Team:Ingest Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and works as expected.
Looking at the code looks the AssetTitleMap
is not translated should we fix that and create and issue for that?
Good point. I'm not sure these strings should ever be translated:
I dimly remember discussions about this, but not the result. @jen-huang do you know more? |
Summary
Fixes #85968
It was probably an oversight that
elasticsearch
assets weren't included in the original implementation. Half of the changes are uncommenting lines that have been commented out before.How to test this
Verify that #85968 has been fixed
Find an integration that contains both elasticsearch and kibana assets. Navigate to that integration's detail page under Fleet->Integrations (I used Nginx for this). Observe that both kind of assets are listed on the left side:
On the integration's detail page, navigate to the Settings tab and click the "Install $INTEGRATION assets" button. Verify that the number of assets to be installed is correct: