Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPM] Include both kibana and elasticsearch assets in package information #88036

Merged
merged 2 commits into from
Jan 13, 2021

Conversation

skh
Copy link
Contributor

@skh skh commented Jan 12, 2021

Summary

Fixes #85968

It was probably an oversight that elasticsearch assets weren't included in the original implementation. Half of the changes are uncommenting lines that have been commented out before.

How to test this

Verify that #85968 has been fixed

Find an integration that contains both elasticsearch and kibana assets. Navigate to that integration's detail page under Fleet->Integrations (I used Nginx for this). Observe that both kind of assets are listed on the left side:
image

On the integration's detail page, navigate to the Settings tab and click the "Install $INTEGRATION assets" button. Verify that the number of assets to be installed is correct:

image

@skh skh added Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 v8.0.0 v7.12.0 and removed v7.11.0 labels Jan 12, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 967.9KB 967.9KB +30.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@skh skh marked this pull request as ready for review January 13, 2021 10:34
@skh skh requested a review from a team January 13, 2021 10:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Feature:EPM)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@skh skh self-assigned this Jan 13, 2021
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works as expected.
Looking at the code looks the AssetTitleMap is not translated should we fix that and create and issue for that?

@skh
Copy link
Contributor Author

skh commented Jan 13, 2021

Looking at the code looks the AssetTitleMap is not translated should we fix that and create and issue for that?

Good point. I'm not sure these strings should ever be translated:

  dashboard: 'Dashboard',
  ilm_policy: 'ILM Policy',
  ingest_pipeline: 'Ingest Pipeline',
  transform: 'Transform',
  index_pattern: 'Index Pattern',
  index_template: 'Index Template',
  component_template: 'Component Template',
  search: 'Saved Search',
  visualization: 'Visualization',
  input: 'Agent input',
  map: 'Map',
  data_stream_ilm_policy: 'Data Stream ILM Policy',

I dimly remember discussions about this, but not the result. @jen-huang do you know more?

@skh skh merged commit 6a55d46 into elastic:master Jan 13, 2021
skh added a commit that referenced this pull request Jan 14, 2021
…tion (#88036) (#88197)

* Return both kibana and elasticsearch assets.

* Fix type complaints.
@skh skh deleted the 85968-show-elasticsearch-assets-too branch January 14, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Asset counter is off when installing package
4 participants