Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Allow to link to Integration without specifying the concrete version #93393

Closed
simitt opened this issue Mar 3, 2021 · 8 comments · Fixed by #103484
Closed

[Fleet] Allow to link to Integration without specifying the concrete version #93393

simitt opened this issue Mar 3, 2021 · 8 comments · Fixed by #103484
Assignees
Labels
Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0

Comments

@simitt
Copy link
Contributor

simitt commented Mar 3, 2021

At the moment the exact version is specified when navigatin to an Integration in Fleet, for example <host>:<port>/app/fleet#/integrations/detail/apm-0.1.0-dev.5/overview.

When linking to an Integration from some other Kibana app, this requires to know about the Integration versions. It would be easier if a URL without the version would just show the installed, or if not installed the latest available, Integration.
Example: <host>:<port>/app/fleet#/integrations/detail/apm/overview.

Edit: this issue is currently blocked until we figure out plans for Integration UI and capacity for that work in 7.14.

@simitt simitt added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@mostlyjason
Copy link
Contributor

@ph I think this is needed to link from the add data UI to the APM integration in Fleet

@jfsiii
Copy link
Contributor

jfsiii commented Mar 10, 2021

cc @ruflin @paul-tavares @neptunian since I know we've debated "always show latest" vs installed in the past

@ruflin
Copy link
Member

ruflin commented Mar 10, 2021

I like the suggestion from @simitt

URL without the version would just show the installed (version), or if not installed the latest available, Integration.

@jfsiii But I remember there was a catch to this?

@jfsiii
Copy link
Contributor

jfsiii commented Mar 10, 2021

@ruflin I don't recall anything specific, but will look into it. I know we have several places that assume/require the latest version, but hopefully that won't affect us here.

@ruflin ruflin added v7.14.0 and removed v7.13.0 labels Apr 17, 2021
@ruflin
Copy link
Member

ruflin commented Apr 17, 2021

Relabeled to 7.14, hope this is ok.

@jen-huang jen-huang changed the title Allow to link to Fleet Integration without specifying the concrete version [Fleet] Allow to link to Integration without specifying the concrete version Apr 28, 2021
@simitt
Copy link
Contributor Author

simitt commented Jun 24, 2021

@ogupte @cauemarcondes this is the issue regarding the latest package.
@jen-huang I see this was moved to TODO some time ago, is this still planned/feasible for 7.14?

@jen-huang
Copy link
Contributor

@simitt Yes, I believe @kpollich will be looking at this.

@kpollich kpollich self-assigned this Jun 28, 2021
kpollich added a commit to kpollich/kibana that referenced this issue Jun 28, 2021
Default to either the installed version of an integration, or the latest
available version based on installation status when a version is not
included in the integration details URL.

Closes elastic#93393
kpollich added a commit that referenced this issue Jun 28, 2021
Default to either the installed version of an integration, or the latest
available version based on installation status when a version is not
included in the integration details URL.

Closes #93393
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jun 28, 2021
Default to either the installed version of an integration, or the latest
available version based on installation status when a version is not
included in the integration details URL.

Closes elastic#93393
kibanamachine added a commit that referenced this issue Jun 28, 2021
Default to either the installed version of an integration, or the latest
available version based on installation status when a version is not
included in the integration details URL.

Closes #93393

Co-authored-by: Kyle Pollich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants