Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Remove metrics:max_buckets setting because it is redundant to histogram:maxBars #94212

Closed
wylieconlon opened this issue Mar 9, 2021 · 2 comments · Fixed by #95639
Closed

[TSVB] Remove metrics:max_buckets setting because it is redundant to histogram:maxBars #94212

wylieconlon opened this issue Mar 9, 2021 · 2 comments · Fixed by #95639
Assignees
@alexwizp
Labels
enhancement New value added to drive a business result Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@wylieconlon
Copy link
Contributor

This setting was made redundant by #83628 in 7.11.0, as it was effectively replaced by the histogram:maxBars setting. Currently if you set metrics:max_buckets to be lower than the histogram:maxBars setting, then you will start to get TSVB warnings.

cc @gchaps since this is related to #93317

cc @alexwizp
@wylieconlon wylieconlon added Feature:TSVB TSVB (Time Series Visual Builder) enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon wylieconlon mentioned this issue Mar 9, 2021
Merged
1 task
@alexwizp alexwizp self-assigned this Mar 16, 2021
alexwizp added a commit to alexwizp/kibana that referenced this issue Mar 16, 2021
@alexwizp
[TSVB] Remove metrics:max_buckets setting because it is redundant to …
dbaf682 
…histogram:maxBars

Closes: elastic#94212
@wylieconlon
Copy link
Contributor Author

@alexwizp you've said that the metrics:max_buckets setting is still relevant because if the user types a date interval manually, then this is the only validation for it? So maybe this setting is still useful?

alexwizp added a commit to alexwizp/kibana that referenced this issue Mar 24, 2021
@alexwizp
[TSVB] Remove metrics:max_buckets setting because it is redundant to …
9c7bcfa 
…histogram:maxBars

Closes: elastic#94212
alexwizp added a commit to alexwizp/kibana that referenced this issue Mar 29, 2021
@alexwizp
[TSVB] Remove metrics:max_buckets setting because it is redundant to …
23f7d6f 
…histogram:maxBars

Closes: elastic#94212
@alexwizp alexwizp mentioned this issue Mar 29, 2021
Merged
alexwizp added a commit that referenced this issue Mar 31, 2021
@alexwizp @kibanamachine
[TSVB] metrics:max_buckets setting should limit buckets on server sid…
ede6b4f 
…e too. (#95639)

* tmp

* [TSVB] Remove metrics:max_buckets setting because it is redundant to histogram:maxBars

Closes: #94212

Co-authored-by: Kibana Machine <[email protected]>
alexwizp added a commit to alexwizp/kibana that referenced this issue Mar 31, 2021
@alexwizp @kibanamachine
[TSVB] metrics:max_buckets setting should limit buckets on server sid…
344ca56 
…e too. (elastic#95639)

* tmp

* [TSVB] Remove metrics:max_buckets setting because it is redundant to histogram:maxBars

Closes: elastic#94212

Co-authored-by: Kibana Machine <[email protected]>
alexwizp added a commit that referenced this issue Mar 31, 2021
@alexwizp @kibanamachine
[TSVB] metrics:max_buckets setting should limit buckets on server sid…
ca51da1 
…e too. (#95639) (#95901)

* tmp

* [TSVB] Remove metrics:max_buckets setting because it is redundant to histogram:maxBars

Closes: #94212

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
enhancement New value added to drive a business result Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TSVB] metrics:max_buckets setting should limit buckets on server side too. alexwizp/kibana
3 participants
@wylieconlon @elasticmachine @alexwizp