-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discover locator #102712
Discover locator #102712
Conversation
Pinging @elastic/kibana-app-services (Team:AppServices) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested Explore underlying data from dashboard to discover and Discover search session which still uses old URL generator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, KibanaApp owned code review, checked out, tested explore underlying data, works as expected. One question, would it be possible to use this generator in our functional tests?
@kertal It is our plan to remove the URL generator in one of the subsequent PRs, so it is better not to use it in any tests; but use locator instead. With regards to functional tests specifically, the functional tests don't know what is used under the hood. So for example "explore underlying data" functional tests just pass. |
I'm aware of this, my question was more, could we use the functionality of the locator to generate links in our functional tests? often the UI is used for defining time ranges necessary for certain tests. doing it directly with a generated URL would be faster |
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Page load bundle
History
To update your PR or re-run it, just comment with: |
@kertal That's a good questions. I'm not sure. Currently canonically you would consume locator through a plugin contract, but to use it in a functional test we would need to load it somehow differently (or expose a back door for functional tests to use plugin contracts). Maybe part of the locator that generates the link, for some locators, could be extracted into a separate file, and then functional tests could import that file. |
* Add Discover locator * Add Discover locator tests * Expose locator for Discover app and deprecate URL generator * Use Discover locator in Explore Underlying Data * Fix explore data unit tests after refactor * fix: 🐛 update Discover plugin mock * style: 💄 remove any * test: 💍 fix test mock * fix: 🐛 adjust property name after refactor * test: 💍 fix tests after refactor Co-authored-by: Vadim Kibana <[email protected]> Co-authored-by: Vadim Kibana <[email protected]>
Summary
Partially addresses #98107
Checklist
Delete any items that are not applicable to this PR.
For maintainers