[jest] use circus runner for the integration tests #102782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
Team:Operations
mshustov
commented
Jun 22, 2021
| // prevents the server to respond | ||
| await delay(30000); | ||
| return res.ok({ body: 'ok' }); | ||
| const done = new Promise<void>((resolve) => { |
There was a problem hiding this comment.
promise + callback style API are not supported simultaneously jestjs/jest#10529
So I didn't migrate core unit tests to circus.
|
Pinging @elastic/kibana-operations (Team:Operations) |
mshustov
added
v7.14.0
v8.0.0
auto-backport
mshustov
changed the title
tylersmalley
approved these changes
Jun 22, 2021
|
@elasticmachine merge upstream |
…s' into use-circus-for-intergration-tests
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 22, 2021
* use circus runner for integration tests * do not use done callback. jestjs/jest#10529 * fix type error
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jun 22, 2021
…102948) * [jest] use circus runner for the integration tests (#102782) * use circus runner for integration tests * do not use done callback. jestjs/jest#10529 * fix type error * disable reporting for so 100k migration Co-authored-by: Mikhail Shustov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I spent a lot of time debugging
Jest did not exit one second after the test run has completedin my integration tests. It’s turned out an exception, thrown from theafterAlllifecycle, interrupts the cleanup logic, but didn't appear in the logs.It seems to be a jest problem, that can be fixed by switching to
jest-circus/runner.Note, that
jest-circus/runnerwill be the default runner fromjest@v27. We will have to fix otherjasmine2occurrences in the codebase later.