-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Index Pattern header to use UI Framework components. #10390
Update Index Pattern header to use UI Framework components. #10390
Conversation
49a0066
to
0504874
Compare
I merged #10560 into this PR, and visually everything looks good. Code looks good too. One consideration: I tend to use contrast to draw the user's attention to controls that I want them to use, or that are generally helpful in a given interface. Here, the delete button is the only one with any contrast, and that's the last button a user is likely to want to use. Personally, I think they should all be gray, since users don't really ever need to touch those controls once they have their index patterns set up. The controls are there, but they don't draw the user's attention. That said, this is sort of a broader interface discussion, and isn't really a blocker on this PR. Just wanted to bring it up. |
Thanks @w33ble, good points! Would you mind extracting your thoughts on the UI into a separate issue? |
@cjcenizal I can do that. You want me to just label it Design and Discuss, or something else? |
@w33ble Can you also add Management? Thanks! |
I just checked this UI in IE10 and IE11 and it looks good. |
Backports PR #10390 **Commit 1:** Update Index Pattern header to use UI Framework components. * Original sha: 0f7ebb7 * Authored by CJ Cenizal <[email protected]> on 2017-02-16T02:04:08Z **Commit 2:** Fix functional tests. * Original sha: 0504874 * Authored by CJ Cenizal <[email protected]> on 2017-02-16T22:42:51Z
Backports PR #10390 **Commit 1:** Update Index Pattern header to use UI Framework components. * Original sha: 0f7ebb7 * Authored by CJ Cenizal <[email protected]> on 2017-02-16T02:04:08Z **Commit 2:** Fix functional tests. * Original sha: 0504874 * Authored by CJ Cenizal <[email protected]> on 2017-02-16T22:42:51Z
Backports PR #10390 **Commit 1:** Update Index Pattern header to use UI Framework components. * Original sha: 0f7ebb7 * Authored by CJ Cenizal <[email protected]> on 2017-02-16T02:04:08Z **Commit 2:** Fix functional tests. * Original sha: 0504874 * Authored by CJ Cenizal <[email protected]> on 2017-02-16T22:42:51Z
I updated some parts of the Index Pattern detail page to use the UI Framework.
Before
After
I made the alerts visible for demonstration purposes only.