Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Index Pattern header to use UI Framework components. #10390

Merged

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Feb 16, 2017

I updated some parts of the Index Pattern detail page to use the UI Framework.

Before

image

image

After

I made the alerts visible for demonstration purposes only.

image

image

@cjcenizal cjcenizal added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. :Management release_note:enhancement v5.4.0 v6.0.0 labels Feb 16, 2017
@cjcenizal cjcenizal force-pushed the improvement/index-pattern-components branch from 49a0066 to 0504874 Compare February 16, 2017 23:19
@w33ble w33ble self-assigned this Feb 22, 2017
@w33ble
Copy link
Contributor

w33ble commented Feb 23, 2017

Now that tabs are making their way into core, #10255 is a more apparent issue.

Also, #10558

@w33ble
Copy link
Contributor

w33ble commented Feb 27, 2017

I merged #10560 into this PR, and visually everything looks good. Code looks good too.

One consideration:

screenshot 2017-02-27 14 10 55

I tend to use contrast to draw the user's attention to controls that I want them to use, or that are generally helpful in a given interface. Here, the delete button is the only one with any contrast, and that's the last button a user is likely to want to use.

Personally, I think they should all be gray, since users don't really ever need to touch those controls once they have their index patterns set up.

screenshot 2017-02-27 14 28 16

The controls are there, but they don't draw the user's attention. That said, this is sort of a broader interface discussion, and isn't really a blocker on this PR. Just wanted to bring it up.

@cjcenizal
Copy link
Contributor Author

Thanks @w33ble, good points! Would you mind extracting your thoughts on the UI into a separate issue?

@w33ble
Copy link
Contributor

w33ble commented Feb 28, 2017

@cjcenizal I can do that. You want me to just label it Design and Discuss, or something else?

@cjcenizal
Copy link
Contributor Author

@w33ble Can you also add Management? Thanks!

@cjcenizal
Copy link
Contributor Author

I just checked this UI in IE10 and IE11 and it looks good.

@cjcenizal cjcenizal merged commit d6bf621 into elastic:master Feb 28, 2017
@cjcenizal cjcenizal deleted the improvement/index-pattern-components branch February 28, 2017 00:21
elastic-jasper added a commit that referenced this pull request Feb 28, 2017
Backports PR #10390

**Commit 1:**
Update Index Pattern header to use UI Framework components.

* Original sha: 0f7ebb7
* Authored by CJ Cenizal <[email protected]> on 2017-02-16T02:04:08Z

**Commit 2:**
Fix functional tests.

* Original sha: 0504874
* Authored by CJ Cenizal <[email protected]> on 2017-02-16T22:42:51Z
cjcenizal added a commit that referenced this pull request Feb 28, 2017
Backports PR #10390

**Commit 1:**
Update Index Pattern header to use UI Framework components.

* Original sha: 0f7ebb7
* Authored by CJ Cenizal <[email protected]> on 2017-02-16T02:04:08Z

**Commit 2:**
Fix functional tests.

* Original sha: 0504874
* Authored by CJ Cenizal <[email protected]> on 2017-02-16T22:42:51Z
cjcenizal pushed a commit that referenced this pull request Feb 28, 2017
Backports PR #10390

**Commit 1:**
Update Index Pattern header to use UI Framework components.

* Original sha: 0f7ebb7
* Authored by CJ Cenizal <[email protected]> on 2017-02-16T02:04:08Z

**Commit 2:**
Fix functional tests.

* Original sha: 0504874
* Authored by CJ Cenizal <[email protected]> on 2017-02-16T22:42:51Z
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:enhancement Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v5.4.0 v6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants