[load testing] remove extra loop and pass simulations to running script #106997

dmlemeshko · 2021-07-28T12:18:25Z

Summary

There is an extra loop that runs the same puppeteer script multiple times before each simulation. This PR fixes it to run only once.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

wayneseymour

Lgtm, but not sure if that export is needed

dmlemeshko · 2021-07-28T14:30:31Z

@elasticmachine merge upstream

kibanamachine · 2021-07-29T00:56:22Z

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

API count

id	before	after	diff
`actions`	-	117	+117
`advancedSettings`	-	23	+23
`alerting`	-	242	+242
`apm`	-	39	+39
`apmOss`	-	4	+4
`banners`	-	9	+9
`bfetch`	-	73	+73
`canvas`	-	6	+6
`cases`	-	445	+445
`charts`	-	190	+190
`cloud`	-	21	+21
`core`	-	2362	+2362
`dashboard`	-	160	+160
`dashboardEnhanced`	-	51	+51
`dashboardMode`	-	11	+11
`data`	-	3741	+3741
`dataEnhanced`	-	16	+16
`dataVisualizer`	-	104	+104
`devTools`	-	10	+10
`discover`	-	81	+81
`discoverEnhanced`	-	39	+39
`embeddable`	-	456	+456
`embeddableEnhanced`	-	14	+14
`encryptedSavedObjects`	-	30	+30
`enterpriseSearch`	-	2	+2
`esUiShared`	-	92	+92
`eventLog`	-	70	+70
`expressionError`	-	12	+12
`expressionImage`	-	4	+4
`expressionMetric`	-	4	+4
`expressionRepeatImage`	-	28	+28
`expressionRevealImage`	-	4	+4
`expressions`	-	2003	+2003
`expressionShape`	-	90	+90
`features`	-	215	+215
`fileUpload`	-	128	+128
`fleet`	-	1140	+1140
`globalSearch`	-	68	+68
`home`	-	94	+94
`indexLifecycleManagement`	-	4	+4
`indexManagement`	-	162	+162
`indexPatternFieldEditor`	-	41	+41
`infra`	-	25	+25
`inspector`	-	101	+101
`kibanaLegacy`	-	66	+66
`kibanaReact`	-	260	+260
`kibanaUtils`	-	551	+551
`lens`	-	207	+207
`licenseApiGuard`	-	8	+8
`licenseManagement`	-	3	+3
`licensing`	-	117	+117
`lists`	-	150	+150
`management`	-	40	+40
`maps`	-	204	+204
`mapsEms`	-	75	+75
`metricsEntities`	-	9	+9
`ml`	-	278	+278
`monitoring`	-	10	+10
`navigation`	-	31	+31
`newsfeed`	-	17	+17
`observability`	-	219	+219
`osquery`	-	11	+11
`presentationUtil`	-	176	+176
`remoteClusters`	-	4	+4
`reporting`	-	133	+133
`rollup`	-	20	+20
`ruleRegistry`	-	60	+60
`runtimeFields`	-	24	+24
`savedObjects`	-	213	+213
`savedObjectsManagement`	-	96	+96
`savedObjectsTagging`	-	54	+54
`savedObjectsTaggingOss`	-	89	+89
`screenshotMode`	-	22	+22
`security`	-	112	+112
`securityOss`	-	12	+12
`securitySolution`	-	1298	+1298
`share`	-	123	+123
`snapshotRestore`	-	23	+23
`spaces`	-	106	+106
`spacesOss`	-	72	+72
`stackAlerts`	-	4	+4
`taskManager`	-	52	+52
`telemetry`	-	42	+42
`telemetryCollectionManager`	-	29	+29
`telemetryCollectionXpack`	-	1	+1
`telemetryManagementSection`	-	14	+14
`timelines`	-	887	+887
`triggersActionsUi`	-	237	+237
`uiActions`	-	127	+127
`uiActionsEnhanced`	-	205	+205
`urlForwarding`	-	15	+15
`usageCollection`	-	57	+57
`visTypeTimeseries`	-	10	+10
`visualizations`	-	247	+247
total			+19351

API count missing comments

id	before	after	diff
`actions`	-	117	+117
`advancedSettings`	-	22	+22
`alerting`	-	234	+234
`apm`	-	39	+39
`apmOss`	-	4	+4
`banners`	-	9	+9
`bfetch`	-	62	+62
`canvas`	-	5	+5
`cases`	-	407	+407
`charts`	-	159	+159
`cloud`	-	21	+21
`core`	-	1081	+1081
`dashboard`	-	137	+137
`dashboardEnhanced`	-	50	+50
`dashboardMode`	-	11	+11
`data`	-	3190	+3190
`dataEnhanced`	-	16	+16
`dataVisualizer`	-	104	+104
`devTools`	-	8	+8
`discover`	-	55	+55
`discoverEnhanced`	-	37	+37
`embeddable`	-	384	+384
`embeddableEnhanced`	-	14	+14
`encryptedSavedObjects`	-	28	+28
`enterpriseSearch`	-	2	+2
`esUiShared`	-	90	+90
`eventLog`	-	70	+70
`expressionError`	-	12	+12
`expressionImage`	-	4	+4
`expressionMetric`	-	4	+4
`expressionRepeatImage`	-	28	+28
`expressionRevealImage`	-	4	+4
`expressions`	-	1569	+1569
`expressionShape`	-	90	+90
`features`	-	97	+97
`fileUpload`	-	128	+128
`fleet`	-	1045	+1045
`globalSearch`	-	14	+14
`home`	-	70	+70
`indexLifecycleManagement`	-	4	+4
`indexManagement`	-	157	+157
`indexPatternFieldEditor`	-	36	+36
`infra`	-	22	+22
`inspector`	-	78	+78
`kibanaLegacy`	-	62	+62
`kibanaReact`	-	230	+230
`kibanaUtils`	-	359	+359
`lens`	-	191	+191
`licenseApiGuard`	-	8	+8
`licenseManagement`	-	3	+3
`licensing`	-	42	+42
`lists`	-	143	+143
`management`	-	40	+40
`maps`	-	203	+203
`mapsEms`	-	75	+75
`metricsEntities`	-	6	+6
`ml`	-	274	+274
`monitoring`	-	10	+10
`navigation`	-	31	+31
`newsfeed`	-	17	+17
`observability`	-	219	+219
`osquery`	-	11	+11
`presentationUtil`	-	149	+149
`remoteClusters`	-	4	+4
`reporting`	-	132	+132
`rollup`	-	20	+20
`ruleRegistry`	-	60	+60
`runtimeFields`	-	19	+19
`savedObjects`	-	199	+199
`savedObjectsManagement`	-	85	+85
`savedObjectsTagging`	-	50	+50
`savedObjectsTaggingOss`	-	50	+50
`screenshotMode`	-	17	+17
`security`	-	51	+51
`securityOss`	-	9	+9
`securitySolution`	-	1247	+1247
`share`	-	83	+83
`snapshotRestore`	-	22	+22
`spacesOss`	-	5	+5
`stackAlerts`	-	4	+4
`taskManager`	-	25	+25
`telemetryCollectionManager`	-	29	+29
`telemetryCollectionXpack`	-	1	+1
`telemetryManagementSection`	-	13	+13
`timelines`	-	768	+768
`triggersActionsUi`	-	228	+228
`uiActions`	-	88	+88
`uiActionsEnhanced`	-	147	+147
`urlForwarding`	-	15	+15
`usageCollection`	-	16	+16
`visTypeTimeseries`	-	10	+10
`visualizations`	-	229	+229
total			+15417

API count with any type

id	before	after	diff
`bfetch`	-	1	+1
`charts`	-	2	+2
`core`	-	148	+148
`dashboard`	-	1	+1
`data`	-	99	+99
`dataVisualizer`	-	3	+3
`embeddable`	-	4	+4
`esUiShared`	-	4	+4
`expressions`	-	58	+58
`fileUpload`	-	4	+4
`fleet`	-	15	+15
`indexManagement`	-	12	+12
`indexPatternFieldEditor`	-	1	+1
`inspector`	-	6	+6
`kibanaLegacy`	-	3	+3
`kibanaReact`	-	5	+5
`kibanaUtils`	-	3	+3
`maps`	-	2	+2
`mapsEms`	-	1	+1
`ml`	-	10	+10
`presentationUtil`	-	3	+3
`reporting`	-	1	+1
`savedObjects`	-	3	+3
`savedObjectsTaggingOss`	-	3	+3
`securitySolution`	-	8	+8
`share`	-	1	+1
`snapshotRestore`	-	1	+1
`timelines`	-	6	+6
`triggersActionsUi`	-	1	+1
`uiActionsEnhanced`	-	2	+2
`visTypeTimeseries`	-	1	+1
`visualizations`	-	13	+13
total			+425

Non-exported public API item count

id	before	after	diff
`actions`	-	7	+7
`advancedSettings`	-	1	+1
`alerting`	-	16	+16
`apm`	-	30	+30
`bfetch`	-	2	+2
`canvas`	-	3	+3
`cases`	-	14	+14
`charts`	-	1	+1
`core`	-	31	+31
`dashboard`	-	9	+9
`data`	-	64	+64
`dataEnhanced`	-	2	+2
`devTools`	-	2	+2
`discover`	-	6	+6
`discoverEnhanced`	-	2	+2
`embeddable`	-	3	+3
`encryptedSavedObjects`	-	3	+3
`esUiShared`	-	1	+1
`eventLog`	-	4	+4
`expressionError`	-	2	+2
`expressionImage`	-	1	+1
`expressionMetric`	-	1	+1
`expressionRevealImage`	-	1	+1
`expressions`	-	5	+5
`features`	-	2	+2
`fileUpload`	-	1	+1
`fleet`	-	8	+8
`globalSearch`	-	5	+5
`home`	-	5	+5
`indexManagement`	-	3	+3
`indexPatternFieldEditor`	-	3	+3
`infra`	-	3	+3
`inspector`	-	4	+4
`kibanaLegacy`	-	1	+1
`kibanaReact`	-	4	+4
`kibanaUtils`	-	8	+8
`lens`	-	23	+23
`licensing`	-	8	+8
`lists`	-	38	+38
`management`	-	5	+5
`maps`	-	11	+11
`metricsEntities`	-	1	+1
`ml`	-	33	+33
`monitoring`	-	2	+2
`navigation`	-	2	+2
`observability`	-	10	+10
`presentationUtil`	-	5	+5
`reporting`	-	14	+14
`ruleRegistry`	-	9	+9
`runtimeFields`	-	2	+2
`savedObjects`	-	5	+5
`screenshotMode`	-	1	+1
`security`	-	6	+6
`securityOss`	-	3	+3
`securitySolution`	-	28	+28
`share`	-	8	+8
`snapshotRestore`	-	1	+1
`taskManager`	-	8	+8
`telemetryCollectionManager`	-	4	+4
`timelines`	-	25	+25
`triggersActionsUi`	-	19	+19
`uiActions`	-	11	+11
`uiActionsEnhanced`	-	10	+10
`usageCollection`	-	2	+2
`visTypeTimeseries`	-	3	+3
`visualizations`	-	12	+12
total			+567

References to deprecated APIs

id	before	after	diff
`actions`	-	8	+8
`alerting`	-	23	+23
`apm`	-	7	+7
`canvas`	-	53	+53
`cases`	-	151	+151
`crossClusterReplication`	-	2	+2
`dashboard`	-	145	+145
`dashboardEnhanced`	-	13	+13
`dataEnhanced`	-	53	+53
`dataVisualizer`	-	16	+16
`discover`	-	129	+129
`discoverEnhanced`	-	21	+21
`embeddable`	-	2	+2
`encryptedSavedObjects`	-	2	+2
`fleet`	-	89	+89
`globalSearch`	-	4	+4
`graph`	-	2	+2
`indexLifecycleManagement`	-	2	+2
`indexManagement`	-	12	+12
`infra`	-	292	+292
`lens`	-	166	+166
`lists`	-	9	+9
`maps`	-	608	+608
`ml`	-	140	+140
`observability`	-	42	+42
`presentationUtil`	-	2	+2
`savedObjects`	-	6	+6
`savedObjectsManagement`	-	18	+18
`savedObjectsTaggingOss`	-	5	+5
`security`	-	2	+2
`securitySolution`	-	828	+828
`stackAlerts`	-	104	+104
`timelines`	-	76	+76
`transform`	-	16	+16
`uptime`	-	11	+11
`urlDrilldown`	-	18	+18
`visTypeTimeseries`	-	12	+12
`visualizations`	-	34	+34
total			+3123

History

💚 Build #141399 succeeded c0d9945
💚 Build #141362 succeeded 078a40d
💚 Build #141299 succeeded 1f35572

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…pt (elastic#106997) * [load testing] remove loop and pass simulations seq * pass string, not array to script * pass var via export Co-authored-by: Kibana Machine <[email protected]>

kibanamachine · 2021-07-29T08:12:44Z

💚 Backport successful

Status	Branch	Result
✅	7.13
✅	7.14
✅	7.x

The backport PRs will be merged automatically after passing CI.

…pt (#106997) (#107119) * [load testing] remove loop and pass simulations seq * pass string, not array to script * pass var via export Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Dzmitry Lemechko <[email protected]>

…pt (#106997) (#107120) * [load testing] remove loop and pass simulations seq * pass string, not array to script * pass var via export Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Dzmitry Lemechko <[email protected]>

…pt (#106997) (#107121) * [load testing] remove loop and pass simulations seq * pass string, not array to script * pass var via export Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Dzmitry Lemechko <[email protected]>

…pt (elastic#106997) * [load testing] remove loop and pass simulations seq * pass string, not array to script * pass var via export Co-authored-by: Kibana Machine <[email protected]>

[load testing] remove loop and pass simulations seq

1f35572

dmlemeshko added v7.14.1 v7.15.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 28, 2021

dmlemeshko marked this pull request as ready for review July 28, 2021 13:32

wayneseymour approved these changes Jul 28, 2021

View reviewed changes

kibanamachine and others added 3 commits July 28, 2021 10:30

Merge branch 'master' into load/avoid-extra-loop

078a40d

pass string, not array to script

c0d9945

pass var via export

0f0bb08

dmlemeshko added the v7.13.5 label Jul 29, 2021

dmlemeshko merged commit e994d14 into elastic:master Jul 29, 2021

dmlemeshko added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 29, 2021

kibanamachine mentioned this pull request Jul 29, 2021

[7.13] [load testing] remove extra loop and pass simulations to running script (#106997) #107119

Merged

kibanamachine mentioned this pull request Jul 29, 2021

[7.14] [load testing] remove extra loop and pass simulations to running script (#106997) #107120

Merged

kibanamachine mentioned this pull request Jul 29, 2021

[7.x] [load testing] remove extra loop and pass simulations to running script (#106997) #107121

Merged

dmlemeshko deleted the load/avoid-extra-loop branch January 31, 2022 12:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[load testing] remove extra loop and pass simulations to running script #106997

[load testing] remove extra loop and pass simulations to running script #106997

dmlemeshko commented Jul 28, 2021

wayneseymour left a comment

dmlemeshko commented Jul 28, 2021

kibanamachine commented Jul 29, 2021

API count

API count missing comments

API count with any type

Non-exported public API item count

References to deprecated APIs

kibanamachine commented Jul 29, 2021

[load testing] remove extra loop and pass simulations to running script #106997

[load testing] remove extra loop and pass simulations to running script #106997

Conversation

dmlemeshko commented Jul 28, 2021

Summary

Checklist

Risk Matrix

For maintainers

wayneseymour left a comment

Choose a reason for hiding this comment

dmlemeshko commented Jul 28, 2021

kibanamachine commented Jul 29, 2021

💚 Build Succeeded

Metrics [docs]

API count

API count missing comments

API count with any type

Non-exported public API item count

References to deprecated APIs

History

kibanamachine commented Jul 29, 2021

💚 Backport successful