-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Remove references to legacy Elasticsearch types #107519
Merged
kpollich
merged 3 commits into
elastic:master
from
kpollich:107179-clean-up-legacy-es-imports
Aug 3, 2021
Merged
[Fleet] Remove references to legacy Elasticsearch types #107519
kpollich
merged 3 commits into
elastic:master
from
kpollich:107179-clean-up-legacy-es-imports
Aug 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpollich
added
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
auto-backport
Deprecated - use backport:version if exact versions are needed
v7.15.0
labels
Aug 3, 2021
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
reviewed
Aug 3, 2021
nchaulet
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
⏳ Build in-progress, with failures
Failed CI StepsHistory
To update your PR or re-run it, just comment with: cc @kpollich |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 3, 2021
* Remove references to legacy elasticsearch types * Fix types * Fix more types
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Aug 3, 2021
…07548) * Remove references to legacy elasticsearch types * Fix types * Fix more types Co-authored-by: Kyle Pollich <[email protected]>
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
* Remove references to legacy elasticsearch types * Fix types * Fix more types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
v7.15.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #107179
Remove references to
elasticsearch
module in Fleet.The non-legacy
elasticsearch/types
module does not export these legacy errors, and I based this PR off of another one linked in the top-level tracking issue (#83910) for this cleanup in which the security team removed references to these legacy errors in their tests: #107135.